Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 330490043: outline for encap (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by mustafa.alabaychi
Modified:
1 month, 4 weeks ago
Reviewers:
safa.ismail.si, mustafa.alabaychi, dima.alissa, Alaiin
CC:
dkostic, iotik2200ht17_ict.kth.se
Visibility:
Public.

Description

added a reply function server>client BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added the encap function. Please review and give suggestions of extension, Thanks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M tun.c View 1 1 chunk +8 lines, -3 lines 1 comment Download
M udp-server.c View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4
mustafa.alabaychi
Here is the reply-to-client function added to udp-server.c. Can you please review. /Mustafa
2 months ago (2017-10-07 09:50:47 UTC) #1
armangungor
A good step for learning & practicing coding in Contiki. This new function called at ...
2 months ago (2017-10-08 21:32:43 UTC) #2
mustafa.alabaychi
Please review. Extension and improvement suggestions are welcome.
2 months ago (2017-10-10 22:12:42 UTC) #3
safa.ismail.SI
2 months ago (2017-10-11 10:37:47 UTC) #4
It is a good way to start as you are modifying the original code "udp-server.c".
However, it is much better if you could provide comments that explains what the
function does.

Regards,
Safa

https://codereview.appspot.com/330490043/diff/20001/tun.c
File tun.c (right):

https://codereview.appspot.com/330490043/diff/20001/tun.c#newcode33
tun.c:33: uip_udp_packet_sendto(tun_conn, pkt_ptr, 48+uip_len,
&UIP_IP_BUF->srcipaddr, UIP_HTONS(UDP_CLIENT_PORT));
you can add a comment that describes how what the "encap" function does.
It is unclear to me how it works.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d