Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(671)

Issue 330470043: new version for HUM including ps/pidstat together, also change code to python function

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by 2016shana2333
Modified:
6 years, 6 months ago
Visibility:
Public.

Description

new version for HUM including ps/pidstat together, also change code to python function BUG=

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -0 lines) Patch
A HUM/HUM_combine.py View 1 chunk +66 lines, -0 lines 6 comments Download

Messages

Total messages: 5
2016shana2333
HUM module with selection of ps and pidstat. Also change old code to using python ...
6 years, 6 months ago (2017-10-05 15:34:12 UTC) #1
Vasileios Papageorgiou
Hi Jiatong! I have just reviewed your code! Check my comments! BR, Vasileios Papageorgiou https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py ...
6 years, 6 months ago (2017-10-05 21:31:05 UTC) #2
younes.tahri3
https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py File HUM/HUM_combine.py (right): https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py#newcode40 HUM/HUM_combine.py:40: number= input('1.ps 2.pidstat Pls input tools number:'); you could ...
6 years, 6 months ago (2017-10-07 10:37:13 UTC) #3
2016shana2333
https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py File HUM/HUM_combine.py (right): https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py#newcode60 HUM/HUM_combine.py:60: cpu2,mem2=ps_read() It is a bug here.
6 years, 6 months ago (2017-10-09 18:41:14 UTC) #4
engr.sikandar.iqbal
6 years, 6 months ago (2017-10-09 20:58:33 UTC) #5
Hi, 
I have reviewed your code.

https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py
File HUM/HUM_combine.py (right):

https://codereview.appspot.com/330470043/diff/1/HUM/HUM_combine.py#newcode42
HUM/HUM_combine.py:42: if(number==1):
Is number==1 and number==2 is representating tools?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b