Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2814)

Issue 330430043: Adds flow to host port in its attached switch

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by Michail.Xirouchakis
Modified:
6 years, 5 months ago
CC:
michail.xirouchakis_gmail.com
Visibility:
Public.

Description

Adds flow to host port in its attached switch. An overall description of the CPM functionality is available in weekly report: https://docs.google.com/document/d/1SRaaDnfsmpT5etjjAaqH1VTb5wxo4lvX4G8QE4ulruA/edit?usp=sharing

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -45 lines) Patch
M cpm/cpm_spf_13.py View 5 chunks +19 lines, -45 lines 6 comments Download

Messages

Total messages: 4
Michail.Xirouchakis
Hello everyone, Pleare review my overall CPM implementation. You can read about its current functionality ...
6 years, 6 months ago (2017-10-03 15:20:47 UTC) #1
Michail.Xirouchakis
6 years, 6 months ago (2017-10-03 20:05:35 UTC) #2
Vasileios Papageorgiou
Hi , Michail! I have just reviewed your code by adding some comments. BR, Vasileios ...
6 years, 6 months ago (2017-10-05 21:09:43 UTC) #3
engr.sikandar.iqbal
6 years, 6 months ago (2017-10-09 21:18:48 UTC) #4
Hi Michail, 
Your code is quite defined, I have made some comments on your code.
BR, 
Sikandar Iqbal

https://codereview.appspot.com/330430043/diff/1/cpm/cpm_spf_13.py
File cpm/cpm_spf_13.py (right):

https://codereview.appspot.com/330430043/diff/1/cpm/cpm_spf_13.py#newcode68
cpm/cpm_spf_13.py:68: if start not in neighbors.keys():
if start not in neighbors.keys():
&
if start not in neighbors.keys():
Are these in comments or part of the code?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b