Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in

Issue 330120043: add some rarely used mensural clefs

Can't Edit
Can't Publish+Mail
Start Review
2 years, 7 months ago by benko.pal
2 years, 7 months ago
pkx166h, mail


add some rarely used mensural clefs and an alias petrucci-g2 to petrucci-g

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M scm/parser-clef.scm View 2 chunks +9 lines, -0 lines 2 comments Download


Total messages: 8
g1 clef occurs in English manuscripts; f2 clef occurs in Ockeghem's Missa prolationum (Chigi codex)
2 years, 7 months ago (2017-09-05 18:07:01 UTC) #1
I am updating the doc to include these new clefs (and add all ancient clefs ...
2 years, 7 months ago (2017-09-10 13:02:25 UTC) #2
https://codereview.appspot.com/330120043/diff/1/scm/parser-clef.scm File scm/parser-clef.scm (right): https://codereview.appspot.com/330120043/diff/1/scm/parser-clef.scm#newcode96 scm/parser-clef.scm:96: ("petrucci-g2" . ("clefs.petrucci.g" -2 0)) On 2017/09/10 13:02:25, pkx166h ...
2 years, 7 months ago (2017-09-10 17:49:50 UTC) #3
> I am updating the doc to include these new clefs (and add all ancient ...
2 years, 7 months ago (2017-09-10 17:52:01 UTC) #4
----- Original Message ----- From: <pkx166h@gmail.com> To: <benko.pal@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Sunday, September 10, ...
2 years, 7 months ago (2017-09-12 10:52:20 UTC) #5
On 2017/09/12 10:52:20, mail_philholmes.net wrote: > ----- Original Message ----- > From: <mailto:pkx166h@gmail.com> > To: ...
2 years, 7 months ago (2017-09-12 14:39:34 UTC) #6
----- Original Message ----- From: <pkx166h@gmail.com> To: <benko.pal@gmail.com>; <mail@philholmes.net> Cc: <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: Tuesday, September ...
2 years, 7 months ago (2017-09-12 14:50:05 UTC) #7
2 years, 7 months ago (2017-09-12 18:45:25 UTC) #8

>> Phil, whatever you can offer to help. I know nothing about Ancient music
>> typesetting and was just basing my additions on what was already in the
>> NR. I had asked a few years ago for some help with the Ancient music NR
>> section

oh, sorry, I missed it.  I'm glad to help (I guess that would mainly
be explaining things about ancient notation).

>> as it really is looking rather odd and has not had any of the
>> tidying up work that I did with Graham all those years ago because only
>> a few people knew enough to know what was wrong or could be improved.
>> I assumed (incorrectly as it turned out) that the #'mensural value was
>> generic for all ancient music types and that it was the clef
>> name/settings that made the output 'Gregorian' vs 'Mensural'. :)

It's the notehead style: vaticana, medicaea, solesmes and hufnagel are
for gregorian, mensural, neomensural and petrucci for mensural music.
I'm not at all sure about kievan -- it seems mensural, but I may well
be mistaken.

>> Although there are a lot of diffs, they are mainly just cut/paste edits
>> so if you can give me some broad education on what values I need to use
>> for a given set of keys sigs that should be enough than you go through
>> every single edit line by line.
>> I ordered the clefs as they appeared in the scm file rather than any
>> alphabetical or notational style order.

I think that's a good order.

>> I figured it would be easier to
>> correct someone's work than get a developer to do the edits themselves,
>> so have at it, let me know what I need to change.
>> To save you (and anyone else who may want to help) you can download what
>> the table looks like when it is compiled from here:
>> https://cloud.woelkli.com/s/dBGXat0NEGVoy5C
>> This is just that Clef section in the appendix so it is a small PDF.

Grouping and ordering is fine.

>> Otherwise tell me what I need to fix or what is not correct etc.
>> If you think removing notes would be better (in this appendix) then I
>> can simply use 'spacers' (or if lilypond-book allows it, nothing at
>> all).
>> James
> I'll have a look at sending you some suggested changes tomorrow - I'm in all
> day so this will be something to work on.
> I think the notes add some value, since they show where middle C is with the
> relevant clef.

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b