ICU ticket #13236: revert some changes from r40307 so that, 1., TestIDNA passes when run in Eclipse…

ICU ticket #13236: revert some changes from r40307 so that, 1., TestIDNA passes when run in Eclipse…

[andy.heninger, 2017-08-17 00:18:48]

https://codereview.appspot.com/330010043/diff/1/main/tests/core/src/com/ibm/i...
File main/tests/core/src/com/ibm/icu/dev/test/stringprep/TestIDNA.java (right):

https://codereview.appspot.com/330010043/diff/1/main/tests/core/src/com/ibm/i...
main/tests/core/src/com/ibm/icu/dev/test/stringprep/TestIDNA.java:707:
src.setLength(0);
This doesn't look right. The incoming src is cleared, is the test then actually
doing anything at all?

If the test is broken, I don't think you need to fix it, it can be disabled and
assigned to someone with expertise in IDNA to figure out what should be done.

[nrunge, 2017-08-17 16:29:51]

On 2017/08/17 00:18:48, andy.heninger wrote:
>
https://codereview.appspot.com/330010043/diff/1/main/tests/core/src/com/ibm/i...
> File main/tests/core/src/com/ibm/icu/dev/test/stringprep/TestIDNA.java
(right):
> 
>
https://codereview.appspot.com/330010043/diff/1/main/tests/core/src/com/ibm/i...
> main/tests/core/src/com/ibm/icu/dev/test/stringprep/TestIDNA.java:707:
> src.setLength(0);
> This doesn't look right. The incoming src is cleared, is the test then
actually
> doing anything at all?
> 
> If the test is broken, I don't think you need to fix it, it can be disabled
and
> assigned to someone with expertise in IDNA to figure out what should be done.

The source clearing has the effect that TestCompareRefImpl() does not go through
the code path on which it tries to load the transliterator. With the translit
dependency taken out from build.xml, TestCompareRefImpl() fails due to class not
found. Clearing the source input is just restoring the previous state.
Having said this, @Ignore'ing TestComparRefImpl() is a better way to handle this
situation, less hacky than clearing the input.

[nrunge, 2017-08-17 20:27:57]

Code review changes

[andy.heninger, 2017-08-17 20:45:14]

LGTM