Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2534)

Issue 329860043: Refactor WifiPhy and WifiPhyStateHelper to eliminate circular declaration of classes

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by ammo6818-vandals.uidaho.edu
Modified:
16 hours, 38 minutes ago
Reviewers:
S. Deronne
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Refactor WifiPhy and WifiPhyStateHelper to eliminate circular declaration of classes

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updates for review comments #

Total comments: 8

Patch Set 3 : Updates for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+632 lines, -458 lines) Patch
M examples/wireless/power-adaptation-interference.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M examples/wireless/wifi-ap.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/wifi-sleep.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/energy/examples/basic-energy-model-test.cc View 1 5 chunks +16 lines, -16 lines 0 comments Download
M src/test/traced/traced-callback-typedef-test-suite.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/helper/athstats-helper.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/helper/athstats-helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/wifi/model/wifi-mac-queue.h View 1 2 1 chunk +3 lines, -85 lines 0 comments Download
M src/wifi/model/wifi-mac-queue.cc View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
A src/wifi/model/wifi-mac-queue-item.h View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A src/wifi/model/wifi-mac-queue-item.cc View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-phy.h View 1 4 chunks +3 lines, -120 lines 0 comments Download
M src/wifi/model/wifi-phy.cc View 1 13 chunks +45 lines, -53 lines 0 comments Download
A src/wifi/model/wifi-phy-listener.h View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
A src/wifi/model/wifi-phy-listener.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A src/wifi/model/wifi-phy-state.h View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-phy-state-helper.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/wifi-phy-state-helper.cc View 1 13 chunks +54 lines, -54 lines 0 comments Download
M src/wifi/model/wifi-radio-energy-model.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/wifi/model/wifi-radio-energy-model.cc View 1 21 chunks +57 lines, -56 lines 0 comments Download
M src/wifi/wscript View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
S. Deronne
https://codereview.appspot.com/329860043/diff/1/examples/wireless/wifi-ap.cc File examples/wireless/wifi-ap.cc (right): https://codereview.appspot.com/329860043/diff/1/examples/wireless/wifi-ap.cc#newcode73 examples/wireless/wifi-ap.cc:73: PhyStateTrace (std::string context, Time start, Time duration, enum WifiPhyState::State ...
6 months, 2 weeks ago (2017-08-05 12:13:38 UTC) #1
ammo6818-vandals.uidaho.edu
Patch updated to address review comments. https://codereview.appspot.com/329860043/diff/1/examples/wireless/wifi-ap.cc File examples/wireless/wifi-ap.cc (right): https://codereview.appspot.com/329860043/diff/1/examples/wireless/wifi-ap.cc#newcode73 examples/wireless/wifi-ap.cc:73: PhyStateTrace (std::string context, ...
6 days, 18 hours ago (2018-02-12 04:02:16 UTC) #2
S. Deronne
OK in general, but please also invite Tom and Stefano to this review. https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-mac-queue-item.h File ...
5 days, 1 hour ago (2018-02-13 21:08:16 UTC) #3
ammo6818-vandals.uidaho.edu
16 hours, 38 minutes ago (2018-02-18 05:37:45 UTC) #4
Updates for review comments uploaded.

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-mac-q...
File src/wifi/model/wifi-mac-queue-item.h (right):

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-mac-q...
src/wifi/model/wifi-mac-queue-item.h:116: #ifndef _WIN32
On 2018/02/13 21:08:16, S. Deronne wrote:
> Why do we need this? This change should also be checked with Stefano.

this was required to compile on Visual Studio.

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-phy-l...
File src/wifi/model/wifi-phy-listener.cc (right):

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-phy-l...
src/wifi/model/wifi-phy-listener.cc:32: }
On 2018/02/13 21:08:16, S. Deronne wrote:
> I don't like to have this empty file, how should we handle with pure interface
> class? Maybe check this with Tom.

This is the only function because the rest are pure virtual.  if we change the
declaration of the destructor to pure virtual, all of the classes that use this
class as a base class will have to be modified.

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-phy-s...
File src/wifi/model/wifi-phy-state.h (right):

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-phy-s...
src/wifi/model/wifi-phy-state.h:54: SLEEP,
On 2018/02/13 21:08:16, S. Deronne wrote:
> check indent

fixed

https://codereview.appspot.com/329860043/diff/20001/src/wifi/model/wifi-phy-s...
src/wifi/model/wifi-phy-state.h:58: OFF
On 2018/02/13 21:08:16, S. Deronne wrote:
> here also

fixed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d