Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5205)

Issue 3298041: Update error message for java_abstract_services => java_generic_services

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by sgk1
Modified:
13 years, 3 months ago
Reviewers:
kenton
Visibility:
Public.

Description

Apparently the option name changed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M compiler/protoc-gen-capnproto-java.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
sgk1
13 years, 5 months ago (2010-11-24 01:56:03 UTC) #1
kenton
13 years, 3 months ago (2011-01-23 22:37:59 UTC) #2
LGTM, submitted

On Tue, Nov 23, 2010 at 5:56 PM, <sgk@google.com> wrote:

> Reviewers: kenton,
>
> Description:
> Apparently the option name changed.
>
> Please review this at http://codereview.appspot.com/3298041/
>
> Affected files:
>  M compiler/protoc-gen-capnproto-java.cc
>
>
> Index: compiler/protoc-gen-capnproto-java.cc
> ===================================================================
> --- a/compiler/protoc-gen-capnproto-java.cc
> +++ b/compiler/protoc-gen-capnproto-java.cc
> @@ -579,7 +579,7 @@
>                 compiler::OutputDirectory* output_directory,
>                 string* error) const {
>     if (file->service_count() > 0 &&
> file->options().java_generic_services()) {
> -      *error = "You must set \"option java_abstract_services = false;\" to
> use "
> +      *error = "You must set \"option java_generic_services = false;\" to
> use "
>                "Captain Proto with this file in Java.";
>       return false;
>     }
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b