Issue 329360044: DateTimeSymbols data loading memory leak

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 329360044: DateTimeSymbols data loading memory leak

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 7 months ago by fabalbon

Modified:
6 years, 7 months ago

Reviewers:
aheninger

Visibility:
Public.

More Reviews

Description

DateTimeSymbols data loading memory leak

Patch Set 2 : Avoid copying array if not used #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -10 lines)			Patch
M	icu4c/source/i18n/dtfmtsym.cpp	View	1	1 chunk	+13 lines, -9 lines	0 comments	Download
M	icu4c/source/test/intltest/dtfmrgts.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	icu4c/source/test/intltest/dtfmrgts.cpp	View		3 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

fabalbon

Andy, This is the fix for the memory leak in DateFormatSymbols. Please take a look. ...

6 years, 7 months ago (2017-10-02 23:40:22 UTC) #2

aheninger

https://codereview.appspot.com/329360044/diff/1/icu4c/source/i18n/dtfmtsym.cpp File icu4c/source/i18n/dtfmtsym.cpp (right): https://codereview.appspot.com/329360044/diff/1/icu4c/source/i18n/dtfmtsym.cpp#newcode1640 icu4c/source/i18n/dtfmtsym.cpp:1640: if (arrays.get(*path) == NULL) { Could you move this ...

6 years, 7 months ago (2017-10-03 00:28:15 UTC) #3

fabalbon

6 years, 7 months ago (2017-10-03 00:37:42 UTC) #5

LGTM

Expand All Messages | Collapse All Messages