Standardize format of `in_color`

Standardize format of `in_color`

The skyline line-pair (as used in `-ddebug-skylines`) used a 0-255 range
for color selection, while other uses use a 0-1 range.

The use of the 0-255 range makes weird output, such as "25500.0000%".

[Ebe123, 2017-09-09 17:25:00]

This is a minor nitpick, just making the format of color commands more
consistent. Found it while trying to fix 3778, but fixing it is a big challenge
I don't think I'm capable of, sadly.

[dak, 2017-09-10 10:27:08]

https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc#...
lily/axis-group-interface.cc:991: .in_color (1, 0, 1));
It's likely mostly a matter of taste but I'd lean towards using 1.0 and 0.0 here
since the arguments are of type Real and it makes it more obvious we are indeed
talking about a fully bright color.  Of course, same with all other occurences.

Other than that, LGTM.

[Dan Eble, 2017-09-10 13:21:21]

On 2017/09/10 10:27:08, dak wrote:
> It's likely mostly a matter of taste but I'd lean towards using 1.0 and 0.0
here
> since ... it makes it more obvious we are indeed talking about a fully bright
color.

+1.0

[Ebe123, 2017-09-14 00:30:53]

Make Real typing more apparent

[Ebe123, 2017-09-14 00:32:13]

Done. Changed other occurrences too.

https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc#...
lily/axis-group-interface.cc:991: .in_color (1, 0, 1));
On 2017/09/10 10:27:06, dak wrote:
> It's likely mostly a matter of taste but I'd lean towards using 1.0 and 0.0
here
> since the arguments are of type Real and it makes it more obvious we are
indeed
> talking about a fully bright color.  Of course, same with all other
occurences.
> 
> Other than that, LGTM.

Acknowledged.