Issue 329020043: [dftimewolf] Simplify recipe definition and config import

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 329020043: [dftimewolf] Simplify recipe definition and config import (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by tomchop1

Modified:
6 years, 8 months ago

Reviewers:
jberggren

CC:
onager, someguyiknow, kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dftimewolf] Simplify recipe definition and config import

Patch Set 2 : Change placeholder credentials, fixed nits in docstrings. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -123 lines)			Patch
M	dftimewolf/cli/dftimewolf_recipes.py	View		5 chunks	+12 lines, -35 lines	0 comments	Download
M	dftimewolf/cli/recipes/local_plaso.py	View		1 chunk	+42 lines, -75 lines	0 comments	Download
M	dftimewolf/config.json	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	dftimewolf/config.py	View	1	2 chunks	+17 lines, -4 lines	0 comments	Download
M	dftimewolf/lib/utils.py	View	1	2 chunks	+59 lines, -0 lines	0 comments	Download
M	tests/test_dftimewolf.py	View		3 chunks	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jberggren

A couple of small things, otherwise LGTM https://codereview.appspot.com/329020043/diff/1/dftimewolf/config.json File dftimewolf/config.json (right): https://codereview.appspot.com/329020043/diff/1/dftimewolf/config.json#newcode2 dftimewolf/config.json:2: "ts_username": "tom", ...

6 years, 8 months ago (2017-08-24 18:05:00 UTC) #2

tomchop1

6 years, 8 months ago (2017-08-28 13:18:18 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close config

Expand All Messages | Collapse All Messages