Issue 328280043: [dfvfs] Added text encoding support to text file helper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 328280043: [dfvfs] Added text encoding support to text file helper (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by Joachim Metz

Modified:
6 years, 8 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfvfs] Added text encoding support to text file helper

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -32 lines)			Patch
M	dfvfs/helpers/text_file.py	View	6 chunks	+18 lines, -8 lines	0 comments	Download
A	test_data/another_file.utf16	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/helpers/text_file.py	View	3 chunks	+50 lines, -25 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Joachim Metz

6 years, 8 months ago (2017-08-21 17:35:56 UTC) #3

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close text_file

Expand All Messages | Collapse All Messages