Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(420)

Issue 328270043: [l2tdevtools] Improved and added tests for dependencies helper (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by Joachim Metz
Modified:
6 years, 8 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, jberggren
Visibility:
Public.

Description

[l2tdevtools] Improved and added tests for dependencies helper

Patch Set 1 : Improved and added tests for dependencies helper #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -9 lines) Patch
M l2tdevtools/dependencies.py View 3 chunks +36 lines, -9 lines 0 comments Download
A test_data/dependencies.ini View 1 chunk +7 lines, -0 lines 0 comments Download
A tests/dependencies.py View 1 chunk +151 lines, -0 lines 0 comments Download
A tests/test_lib.py View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
6 years, 8 months ago (2017-08-17 05:29:44 UTC) #1
Joachim Metz
Code updated.
6 years, 8 months ago (2017-08-17 05:42:34 UTC) #2
onager
LGTM
6 years, 8 months ago (2017-08-20 12:53:03 UTC) #3
Joachim Metz
6 years, 8 months ago (2017-08-20 12:59:00 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close deps
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b