Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(894)

Issue 328180043: [dftimewolf] Removed convoluted imports, make config a class

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 2 days ago by tomchop1
Modified:
5 days, 21 hours ago
Reviewers:
onager
CC:
jberggren, someguyiknow, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dftimewolf] Removed convoluted imports, make config a class. - Removed dynamic imports feature - internals.py - Configuration is now globally stored in a class with setters and getters - user_config.py.sample - this is where the user configuration goes; loaded modules, recipes, specific configuration tweaks. - local_plaso.py - recipes are now classes since they can absorb global configuration settings when loaded The UX is a bit less straightforward but it simplifies the codebase a lot.

Patch Set 1 #

Patch Set 2 : Check on user config file (fixes tests) #

Total comments: 1

Patch Set 3 : Simpler recipe & module import; fix tests; travis file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -201 lines) Patch
M .gitignore View 1 chunk +3 lines, -0 lines 0 comments Download
A .travis.yml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M dftimewolf/cli/dftimewolf_recipes.py View 1 2 5 chunks +20 lines, -11 lines 0 comments Download
M dftimewolf/cli/recipes/local_plaso.py View 1 chunk +76 lines, -42 lines 0 comments Download
A dftimewolf/config.json View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A dftimewolf/config.py View 1 2 1 chunk +141 lines, -0 lines 0 comments Download
D dftimewolf/dftimewolf.json View 1 chunk +0 lines, -9 lines 0 comments Download
M dftimewolf/internals.py View 1 2 1 chunk +0 lines, -131 lines 0 comments Download
M dftimewolf/lib/collectors/filesystem.py View 1 chunk +1 line, -1 line 0 comments Download
M dftimewolf/lib/processors/localplaso.py View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5
tomchop1
3 weeks, 2 days ago (2017-07-28 08:51:29 UTC) #1
tomchop1
Code updated.
1 week, 6 days ago (2017-08-07 11:29:38 UTC) #2
onager
On 2017/08/07 11:29:38, tomchop1 wrote: > Code updated. Tests still don't work, as timewolf_recipes is ...
1 week, 6 days ago (2017-08-07 12:58:46 UTC) #3
onager
https://codereview.appspot.com/328180043/diff/20001/dftimewolf/internals.py File dftimewolf/internals.py (right): https://codereview.appspot.com/328180043/diff/20001/dftimewolf/internals.py#newcode6 dftimewolf/internals.py:6: class Config(object): Rename file to config, if that's all ...
1 week, 6 days ago (2017-08-07 13:00:10 UTC) #4
tomchop1
5 days, 21 hours ago (2017-08-14 15:40:35 UTC) #5
Code updated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted