Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1535)

Issue 328170043: NS-3 GSoC 2017 LTE CA handover milestone 2 and 3

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by ilabdsf
Modified:
1 year, 11 months ago
Reviewers:
biljana.bojovic
Visibility:
Public.

Description

NS-3 GSoC 2017 LTE CA handover milestone 2 and 3

Patch Set 1 #

Total comments: 1

Patch Set 2 : NS-3 GSoC 2017 LTE CA handover milestone 2 and 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1537 lines, -818 lines) Patch
M src/lte/helper/emu-epc-helper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/helper/emu-epc-helper.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M src/lte/helper/epc-helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/helper/lte-helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/lte/helper/lte-helper.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/lte/helper/point-to-point-epc-helper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/helper/point-to-point-epc-helper.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/lte/model/a2-a4-rsrq-handover-algorithm.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/lte/model/a2-a4-rsrq-handover-algorithm.cc View 1 5 chunks +8 lines, -9 lines 0 comments Download
M src/lte/model/a3-rsrp-handover-algorithm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/lte/model/a3-rsrp-handover-algorithm.cc View 1 3 chunks +43 lines, -43 lines 0 comments Download
M src/lte/model/epc-mme.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/epc-mme.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/lte/model/epc-sgw-pgw-application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/epc-sgw-pgw-application.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/lte/model/epc-x2.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/lte/model/epc-x2.cc View 9 chunks +25 lines, -23 lines 0 comments Download
M src/lte/model/lte-enb-component-carrier-manager.h View 1 1 chunk +8 lines, -4 lines 0 comments Download
M src/lte/model/lte-enb-net-device.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-net-device.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M src/lte/model/lte-enb-rrc.h View 1 6 chunks +14 lines, -7 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 1 19 chunks +239 lines, -130 lines 0 comments Download
M src/lte/model/lte-ffr-distributed-algorithm.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-ffr-enhanced-algorithm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/lte-ffr-soft-algorithm.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-fr-soft-algorithm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/lte-fr-strict-algorithm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/lte/model/lte-handover-management-sap.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-rrc-header.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-header.cc View 1 10 chunks +182 lines, -147 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 1 3 chunks +22 lines, -22 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-component-carrier-manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-ue-cphy-sap.h View 1 3 chunks +28 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-phy.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-phy.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 1 5 chunks +9 lines, -43 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 1 25 chunks +109 lines, -124 lines 0 comments Download
M src/lte/model/no-op-component-carrier-manager.cc View 9 chunks +58 lines, -127 lines 0 comments Download
M src/lte/test/epc-test-s1u-downlink.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/lte/test/epc-test-s1u-uplink.cc View 1 chunk +3 lines, -1 line 0 comments Download
A src/lte/test/lte-test-primary-cell-change.h View 1 chunk +124 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-primary-cell-change.cc View 1 1 chunk +219 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-secondary-cell-handover.cc View 1 1 chunk +204 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-ue-measurements.cc View 1 11 chunks +27 lines, -27 lines 0 comments Download
M src/lte/test/test-asn1-encoding.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/lte/test/test-lte-handover-delay.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/lte/wscript View 1 3 chunks +2 lines, -1 line 0 comments Download
M src/spectrum/model/multi-model-spectrum-channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/spectrum/model/multi-model-spectrum-channel.cc View 2 chunks +24 lines, -16 lines 0 comments Download
M src/spectrum/model/single-model-spectrum-channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/spectrum/model/single-model-spectrum-channel.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/spectrum/model/spectrum-channel.h View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Biljana Bojović
I reviewed the code, and it seems all fine to me. This code could be ...
1 year, 12 months ago (2017-08-24 09:40:18 UTC) #1
Biljana Bojović
This looks good to me. Are these new test passing, and in general are the ...
1 year, 11 months ago (2017-09-01 15:12:18 UTC) #2
ilabdsf
1 year, 11 months ago (2017-09-01 15:55:28 UTC) #3
On 2017/09/01 15:12:18, Biljana Bojović wrote:
> This looks good to me. Are these new test passing, and in general are the rest
> of LTE test passing ok with these changes in the code?

All the tests pass in my BitBucket repository at
https://bitbucket.org/labdsf/ns-3-dev and code here is the same.

If you want to run the tests it is easier to just clone my repository and
compile it, code review is just so everyone with Google account can leave
comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b