NS-3 GSoC 2017 LTE CA handover milestone 2 and 3

NS-3 GSoC 2017 LTE CA handover milestone 2 and 3

[Biljana Bojović, 2017-08-24 09:40:18]

I reviewed the code, and it seems all fine to me. This code could be merged to
ns-3-dev.

Also, the documentation should be updated, to explain these new functionalities.

https://codereview.appspot.com/328170043/diff/1/src/lte/model/epc-x2.cc
File src/lte/model/epc-x2.cc (right):

https://codereview.appspot.com/328170043/diff/1/src/lte/model/epc-x2.cc#newco...
src/lte/model/epc-x2.cc:208: params.sourceCellId   =
cellsInfo->m_remoteCellIds.at (0);
Can you please explain and also add a comment in the code why the fetched cell
is at 0 position? I understand that in the case of single cell at eNb, the index
has to be 0, but in the case of various it does not matter which one it is since
the eNb can be identified by any of its cells. Is this correct?

[Biljana Bojović, 2017-09-01 15:12:18]

This looks good to me. Are these new test passing, and in general are the rest
of LTE test passing ok with these changes in the code?

[ilabdsf, 2017-09-01 15:55:28]

On 2017/09/01 15:12:18, Biljana Bojović wrote:
> This looks good to me. Are these new test passing, and in general are the rest
> of LTE test passing ok with these changes in the code?

All the tests pass in my BitBucket repository at
https://bitbucket.org/labdsf/ns-3-dev and code here is the same.

If you want to run the tests it is easier to just clone my repository and
compile it, code review is just so everyone with Google account can leave
comments.