Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(716)

Issue 328140043: Add usage of OpenType font feature to the documents

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by trueroad
Modified:
4 months ago
Reviewers:
pkx166h, lemzwerg, tisimst
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5164: Doc: Add usage of OpenType font feature This commit adds the usage of OpenType font feature added in Issue 1388 to the document.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Add full feature list and indexed feature #

Patch Set 3 : Add notes and identification way #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M Documentation/changes.tely View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M Documentation/notation/text.itely View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 21
pkx166h
https://codereview.appspot.com/328140043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/notation/text.itely#newcode1464 Documentation/notation/text.itely:1464: Would it be appropriate to add something after this ...
4 months, 2 weeks ago (2017-07-26 15:38:12 UTC) #1
tisimst
https://codereview.appspot.com/328140043/diff/1/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/notation/text.itely#newcode1464 Documentation/notation/text.itely:1464: On 2017/07/26 15:38:12, pkx166h wrote: > Would it be ...
4 months, 2 weeks ago (2017-07-26 16:01:14 UTC) #2
lemzwerg
LGTM https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely#newcode1037 Documentation/changes.tely:1037: It would be nice to have an example ...
4 months, 2 weeks ago (2017-07-26 20:09:33 UTC) #3
trueroad
Add full feature list and indexed feature
4 months, 2 weeks ago (2017-07-27 13:43:59 UTC) #4
trueroad
Thank you for your reviewing. https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely#newcode1037 Documentation/changes.tely:1037: On 2017/07/26 20:09:33, lemzwerg ...
4 months, 2 weeks ago (2017-07-27 13:47:01 UTC) #5
lemzwerg
Thanks for the additions. LGTM.
4 months, 2 weeks ago (2017-07-27 20:51:06 UTC) #6
tisimst
On 2017/07/27 13:47:01, trueroad wrote: > Thank you for your reviewing. > > https://codereview.appspot.com/328140043/diff/1/Documentation/changes.tely > ...
4 months, 1 week ago (2017-07-31 16:16:40 UTC) #7
lemzwerg
> This is really great! Do you happen know what the current limitations are? Or ...
4 months, 1 week ago (2017-07-31 16:58:40 UTC) #8
tisimst
On 2017/07/31 16:58:40, lemzwerg wrote: > In general, Pango is agnostic of the features themselves, ...
4 months, 1 week ago (2017-07-31 17:16:55 UTC) #9
lemzwerg
> If Pango really is agnostic of the features, that is really exciting and a ...
4 months, 1 week ago (2017-07-31 17:48:10 UTC) #10
tisimst
On 2017/07/31 17:48:10, lemzwerg wrote: > > If Pango really is agnostic of the features, ...
4 months, 1 week ago (2017-07-31 17:55:29 UTC) #11
lemzwerg
> I'm not aware of such an online tool. I've posted a question on Typedrawers. ...
4 months, 1 week ago (2017-08-01 05:37:00 UTC) #12
trueroad
Add notes and identification way
4 months, 1 week ago (2017-08-01 15:05:46 UTC) #13
trueroad
On 2017/08/01 15:05:46, trueroad wrote: > Add notes and identification way If I understand correctly, ...
4 months, 1 week ago (2017-08-01 15:08:11 UTC) #14
tisimst
On 2017/08/01 15:08:11, trueroad wrote: > On 2017/08/01 15:05:46, trueroad wrote: > > Add notes ...
4 months, 1 week ago (2017-08-01 15:18:07 UTC) #15
tisimst
On 2017/07/31 17:55:29, tisimst wrote: > On 2017/07/31 17:48:10, lemzwerg wrote: > > It's not ...
4 months, 1 week ago (2017-08-01 16:28:35 UTC) #16
lemzwerg
> If I'm not mistaken, you don't need to specify the script/language. > That's part ...
4 months, 1 week ago (2017-08-01 17:36:37 UTC) #17
lemzwerg
> I looked into the latest Harfbuzz internals, and it looks like > the list ...
4 months, 1 week ago (2017-08-01 17:49:47 UTC) #18
tisimst
On 2017/08/01 17:49:47, lemzwerg wrote: > > I looked into the latest Harfbuzz internals, and ...
4 months, 1 week ago (2017-08-01 17:53:03 UTC) #19
lemzwerg
> I very much appreciate your insight and correction. So, there's no > reason to ...
4 months, 1 week ago (2017-08-01 18:06:57 UTC) #20
trueroad
4 months ago (2017-08-07 21:58:53 UTC) #21
I've pushed to staging.

commit 07125596018d32e3235e80627915cfac77323272
Date:   Wed Jul 26 21:04:33 2017 +0900
Issue 5164: Doc: Add usage of OpenType font feature
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d