Issue 328120043: [dfvfs] Made Unicode strings the default #204 and updated docstrings #182

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 328120043: [dfvfs] Made Unicode strings the default #204 and updated docstrings #182 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 9 months ago by Joachim Metz

Modified:
6 years, 9 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfvfs] Made Unicode strings the default #204 and updated docstrings #182

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+104 lines, -63 lines)			Patch
M	dfvfs/lib/definitions.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/analyzer/analyzer.py	View	15 chunks	+31 lines, -29 lines	0 comments	Download
M	tests/analyzer/specification.py	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/compression/bzip2_decompressor.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compression/manager.py	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/compression/test_lib.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compression/xz_decompressor.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compression/zlib_decompressor.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/credentials/keychain.py	View	2 chunks	+9 lines, -7 lines	0 comments	Download
M	tests/encoding/base16_decoder.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/encoding/base32_decoder.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/encoding/base64_decoder.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/encoding/manager.py	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/encoding/test_lib.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/encryption/aes_decrypter.py	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	tests/encryption/blowfish_decrypter.py	View	5 chunks	+7 lines, -5 lines	0 comments	Download
M	tests/encryption/des3_decrypter.py	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	tests/encryption/manager.py	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/encryption/rc4_decrypter.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/encryption/test_lib.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/test_lib.py	View	3 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Joachim Metz

6 years, 9 months ago (2017-07-27 06:10:50 UTC) #3

merged via github due to pylint 1.7 linting conflicts

Expand All Messages | Collapse All Messages