Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(947)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 328010043: [dftimewolf] Change the way dynamic imports work (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by tomchop1
Modified:
6 years, 9 months ago
Reviewers:
someguyiknow, onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dftimewolf] Change the way dynamic imports work

Patch Set 1 #

Patch Set 2 : Added onager as reviewer #

Total comments: 4

Patch Set 3 : Change place for onager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M dftimewolf/internals.py View 4 chunks +6 lines, -4 lines 0 comments Download
M utils/review.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
tomchop1
6 years, 9 months ago (2017-07-11 12:46:03 UTC) #1
tomchop1
Code updated.
6 years, 9 months ago (2017-07-11 13:18:46 UTC) #2
onager
https://codereview.appspot.com/328010043/diff/20001/utils/review.py File utils/review.py (right): https://codereview.appspot.com/328010043/diff/20001/utils/review.py#newcode83 utils/review.py:83: u'jberggren@gmail.com', Please add onager@deerpie.com here https://codereview.appspot.com/328010043/diff/20001/utils/review.py#newcode139 utils/review.py:139: return reviewers[0]+',onager@deerpie.com' ...
6 years, 9 months ago (2017-07-11 15:44:06 UTC) #3
onager
https://codereview.appspot.com/328010043/diff/20001/utils/review.py File utils/review.py (right): https://codereview.appspot.com/328010043/diff/20001/utils/review.py#newcode83 utils/review.py:83: u'jberggren@gmail.com', Please add onager@deerpie.com here https://codereview.appspot.com/328010043/diff/20001/utils/review.py#newcode139 utils/review.py:139: return reviewers[0]+',onager@deerpie.com' ...
6 years, 9 months ago (2017-07-11 15:44:06 UTC) #4
tomchop1
Code updated.
6 years, 9 months ago (2017-07-11 15:49:17 UTC) #5
tomchop1
https://codereview.appspot.com/328010043/diff/20001/utils/review.py File utils/review.py (right): https://codereview.appspot.com/328010043/diff/20001/utils/review.py#newcode83 utils/review.py:83: u'jberggren@gmail.com', On 2017/07/11 15:44:06, onager wrote: > Please add ...
6 years, 9 months ago (2017-07-11 15:49:49 UTC) #6
onager
LGTM
6 years, 9 months ago (2017-07-12 18:39:49 UTC) #7
tomchop1
6 years, 9 months ago (2017-07-12 21:55:42 UTC) #8 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close new_imports
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b