Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 327620043: make metronomeMarkFormatter more flexible

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Malte Meyn
Modified:
1 month, 1 week ago
Reviewers:
dak, thomasmorley651, kieren_macmillan, x.scheuer
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

make metronomeMarkFormatter more flexible This adds the context properties tempoEquationText, tempoBetweenText and tempoShowParentheses as shown in http://lsr.di.unimi.it/LSR/Item?id=1008 It also allows to scale the size of the notes in a metronome mark independently from or rather relatively to the text and numbers. I added this possibility because http://lsr.di.unimi.it/LSR/Item?id=1008 suggests smaller note sizes; so there seems to be a need for that. The default values are chosen so that the whole thing is backwards compatible; to achieve this, tempoShowParentheses accepts not only boolean values but also the symbol 'if-text. I chose the name tempoShowParentheses instead of tempoHideParentheses because this property also allows parenthesizing text-less MetronomeMarks. Contains regtests.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -16 lines) Patch
A input/regression/metronome-mark-formatter-extended.ly View 1 chunk +36 lines, -0 lines 0 comments Download
A input/regression/metronome-mark-note-size.ly View 1 chunk +22 lines, -0 lines 0 comments Download
M lily/metronome-engraver.cc View 1 chunk +5 lines, -1 line 0 comments Download
M scm/define-context-properties.scm View 1 chunk +8 lines, -0 lines 0 comments Download
M scm/translation-functions.scm View 2 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 25
dak
I think this approach is a rather bad tradeoff between additional context properties and actual ...
2 months ago (2017-10-10 16:29:05 UTC) #1
Malte Meyn
On 2017/10/10 16:29:05, dak wrote: > I think this approach is a rather bad tradeoff ...
2 months ago (2017-10-10 18:47:14 UTC) #2
x.scheuer_gmail.com
Hello, It is nice to see you working on adding new functionalities directly into LilyPond, ...
2 months ago (2017-10-11 08:30:46 UTC) #3
dak
Xavier Scheuer <x.scheuer@gmail.com> writes: > Hello, > > It is nice to see you working ...
2 months ago (2017-10-11 08:34:54 UTC) #4
Malte Meyn
On 2017/10/10 18:47:14, Malte Meyn wrote: > > I think it would make sense to ...
2 months ago (2017-10-12 06:22:22 UTC) #5
dak
On 2017/10/12 06:22:22, Malte Meyn wrote: > On 2017/10/10 18:47:14, Malte Meyn wrote: > > ...
2 months ago (2017-10-12 07:23:51 UTC) #6
Malte Meyn
On 2017/10/12 07:23:51, dak wrote: > Should we provide markup functions for > the various ...
2 months ago (2017-10-12 08:04:49 UTC) #7
Malte Meyn
I accidentally hit “Send Message” … Here is the last paragraph again and fixed: That ...
2 months ago (2017-10-12 08:07:08 UTC) #8
Malte Meyn
On 2017/10/12 08:04:49, Malte Meyn wrote: > And I really would like to have the ...
2 months ago (2017-10-12 08:19:52 UTC) #9
dak
On 2017/10/12 08:19:52, Malte Meyn wrote: > On 2017/10/12 08:04:49, Malte Meyn wrote: > > ...
2 months ago (2017-10-12 08:24:36 UTC) #10
Malte Meyn
How would that reflect that parentheses are shown if and only if text is present? ...
2 months ago (2017-10-12 08:27:51 UTC) #11
dak
On 2017/10/12 08:27:51, Malte Meyn wrote: > How would that reflect that parentheses are shown ...
2 months ago (2017-10-12 08:53:31 UTC) #12
thomasmorley651
On 2017/10/12 08:53:31, dak wrote: > On 2017/10/12 08:27:51, Malte Meyn wrote: > > How ...
2 months ago (2017-10-12 21:54:00 UTC) #13
kieren_macmillan_sympatico.ca
Hi Harm, > I'd like to suggest a little different. > [...] > What do ...
2 months ago (2017-10-13 05:10:38 UTC) #14
Malte Meyn
On 2017/10/12 21:54:00, thomasmorley651 wrote: > { > \override Score.MetronomeMark.details = > #(list > (cons ...
1 month, 4 weeks ago (2017-10-15 08:51:31 UTC) #15
Malte Meyn
Maybe we should think about another subproperty for text like "M. M." that is placed ...
1 month, 4 weeks ago (2017-10-15 09:31:37 UTC) #16
dak
On 2017/10/15 09:31:37, Malte Meyn wrote: > Maybe we should think about another subproperty for ...
1 month, 4 weeks ago (2017-10-15 09:36:25 UTC) #17
kieren_macmillan_sympatico.ca
Hi David, > I think it's rather obvious that we won't get something that caters ...
1 month, 4 weeks ago (2017-10-15 13:09:30 UTC) #18
thomasmorley651
On 2017/10/10 18:47:14, Malte Meyn wrote: > \tempo "" 4 = 120 → (𝅘𝅥 = ...
1 month, 3 weeks ago (2017-10-15 19:50:50 UTC) #19
thomasmorley651
On 2017/10/15 13:09:30, kieren_macmillan_sympatico.ca wrote: > Hi David, > > > I think it's rather ...
1 month, 3 weeks ago (2017-10-15 20:03:08 UTC) #20
kieren_macmillan_sympatico.ca
Hi Harm (et al.), > On the tracker I posted a more elaborated code. > ...
1 month, 3 weeks ago (2017-10-16 03:23:04 UTC) #21
dak
On 2017/10/16 03:23:04, kieren_macmillan_sympatico.ca wrote: > Hi Harm (et al.), > > > On the ...
1 month, 3 weeks ago (2017-10-16 07:29:16 UTC) #22
Malte Meyn
On 2017/10/15 19:50:50, thomasmorley651 wrote: > On 2017/10/10 18:47:14, Malte Meyn wrote: > > > ...
1 month, 1 week ago (2017-10-30 07:44:49 UTC) #23
dak
lilypond@maltemeyn.de writes: > On 2017/10/15 19:50:50, thomasmorley651 wrote: >> On 2017/10/10 18:47:14, Malte Meyn wrote: ...
1 month, 1 week ago (2017-10-30 07:53:19 UTC) #24
Malte Meyn
1 month, 1 week ago (2017-10-30 15:20:07 UTC) #25
On 2017/10/30 07:44:49, Malte Meyn wrote:
> Apart from that I posted a code at
> https://sourceforge.net/p/testlilyissues/issues/5215/#505b that tries to go
into
> the direction of Kieren’s latest suggestion.

This approach would work if it didn’t have to collect all needed information
from grob, context and event properties but only from grob properties.
Currently, the grob property 'text is set by the metronomeMarkFormatter which
takes input from event (f. e. 'text) and context (f. e. 'tempoHideNote)
properties.

Ok, technically, it’s possible to get the other properties (as one can see at
the bottom of that code example, but that would be really confusing (I don’t
know a better word for the German “unübersichtlich”).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d