Install missing packages for add-apt-repository.

Install missing packages for add-apt-repository.

Also use absolute paths to commands executed
with sudo privileges.

Tests: `make check`

QA:

1)  Create a saucy LXC sharing your home directory,
    e.g. `sudo lxc-create -t ubuntu -n quickstart -f <MY-TEMPLATE> \ 
          -- -r saucy -a amd64 -b $USER` 
    where "quickstart" is the name of the container,
    "-r" is used to specify the release to use,
    "-b" binds the home directory of the specified user,
    and <MY-TEMPLATE> is a file with the following contents:
        lxc.network.type=veth
        lxc.network.link=lxcbr0
        lxc.network.flags=up
    I assume you already have:
      - a juju home containing the environments.yaml file 
        configured with an "ec2" ec2 environment;
      - your ssh keys properly set up;
      - run the tests with `make check` as described above.
    So at this point the container does not have juju
    installed, but the juju home and ssh keys are
    available, and so the branch with a configured testing
    virtualenv. We already have cards for environment
    creation and ssh keys handling.
2)  Start the LXC instance (`sudo lxc-start -n quickstart`).
3)  Open a console inside the LXC with
    `sudo lxc-console -n quickstart`, log in using your user
    credentials, and cd into the directory where you checked 
    out this branch.
4)  Run `.venv/bin/python juju-quickstart -e ec2 --no-browser`.
    You should be asked the sudo password in order to add
    the missing PPA and install juju-core and lxc.
    Note that installing the packages can take some minutes.
    The process will then proceed as usual.
5)  Run `.venv/bin/python juju-quickstart -e ec2 --no-browser`
    again: this time no packages installation should be required,
    and quickstart just reuses the existing environment.
6)  From the host, stop and destroy the LXC container:
    `sudo lxc-stop -n quickstart` and `sudo lxc-destroy -n quickstart`.
7)  Destroy your ec2 environment.

Thank you!

https://code.launchpad.net/~frankban/juju-quickstart/sudo-fixes/+merge/196692

(do not edit description out of merge proposal)

[frankban, 2013-11-26 10:54:24]

Please take a look.

[frankban, 2013-11-26 14:09:13]

Please take a look.

[bac, 2013-11-26 14:26:24]

Code LGTM.  QA had one problem, which you've already fixed.  QA on patch was
successful.

[rharding, 2013-11-26 14:36:25]

LGTM with a question and suggestion.

https://codereview.appspot.com/32760043/diff/20001/quickstart/app.py
File quickstart/app.py (right):

https://codereview.appspot.com/32760043/diff/20001/quickstart/app.py#newcode63
quickstart/app.py:63: # The lxc package is required to create the LXC containers
used by
shouldn't this dep be based on if your env is lxc vs just if the lxc-ls command
is available? Will this try to install lxc if I'm using quickstart on non-local
provider installs?

https://codereview.appspot.com/32760043/diff/20001/quickstart/app.py#newcode166
quickstart/app.py:166: '/usr/bin/juju', 'api-endpoints', '-e', env_name,
'--format', 'json')
maybe providing a COMMANDS or something list where this is hard coded will be
easier to maintain and less finding of paths through the code.

[frankban, 2013-11-26 15:10:15]

On 2013/11/26 14:36:25, rharding wrote:
> LGTM with a question and suggestion.
> 
> https://codereview.appspot.com/32760043/diff/20001/quickstart/app.py
> File quickstart/app.py (right):
> 
> https://codereview.appspot.com/32760043/diff/20001/quickstart/app.py#newcode63
> quickstart/app.py:63: # The lxc package is required to create the LXC
containers
> used by
> shouldn't this dep be based on if your env is lxc vs just if the lxc-ls
command
> is available? Will this try to install lxc if I'm using quickstart on
non-local
> provider installs?
> 
>
https://codereview.appspot.com/32760043/diff/20001/quickstart/app.py#newcode166
> quickstart/app.py:166: '/usr/bin/juju', 'api-endpoints', '-e', env_name,
> '--format', 'json')
> maybe providing a COMMANDS or something list where this is hard coded will be
> easier to maintain and less finding of paths through the code.

Both good points, thank you.
We agreed they are out of scope for this branch, so I'll create cards.

[frankban, 2013-11-26 15:12:44]

*** Submitted:

Install missing packages for add-apt-repository.

Also use absolute paths to commands executed
with sudo privileges.

Tests: `make check`

QA:

1)  Create a saucy LXC sharing your home directory,
    e.g. `sudo lxc-create -t ubuntu -n quickstart -f <MY-TEMPLATE> \ 
          -- -r saucy -a amd64 -b $USER` 
    where "quickstart" is the name of the container,
    "-r" is used to specify the release to use,
    "-b" binds the home directory of the specified user,
    and <MY-TEMPLATE> is a file with the following contents:
        lxc.network.type=veth
        lxc.network.link=lxcbr0
        lxc.network.flags=up
    I assume you already have:
      - a juju home containing the environments.yaml file 
        configured with an "ec2" ec2 environment;
      - your ssh keys properly set up;
      - run the tests with `make check` as described above.
    So at this point the container does not have juju
    installed, but the juju home and ssh keys are
    available, and so the branch with a configured testing
    virtualenv. We already have cards for environment
    creation and ssh keys handling.
2)  Start the LXC instance (`sudo lxc-start -n quickstart`).
3)  Open a console inside the LXC with
    `sudo lxc-console -n quickstart`, log in using your user
    credentials, and cd into the directory where you checked 
    out this branch.
4)  Run `.venv/bin/python juju-quickstart -e ec2 --no-browser`.
    You should be asked the sudo password in order to add
    the missing PPA and install juju-core and lxc.
    Note that installing the packages can take some minutes.
    The process will then proceed as usual.
5)  Run `.venv/bin/python juju-quickstart -e ec2 --no-browser`
    again: this time no packages installation should be required,
    and quickstart just reuses the existing environment.
6)  From the host, stop and destroy the LXC container:
    `sudo lxc-stop -n quickstart` and `sudo lxc-destroy -n quickstart`.
7)  Destroy your ec2 environment.

Thank you!

R=bac, rharding
CC=
https://codereview.appspot.com/32760043