Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1822)

Issue 3275: message condition params with a single, value-less pair

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 9 months ago by markluffel
Modified:
6 months, 2 weeks ago
Reviewers:
azuercher, tparikh
Base URL:
https://svn.appcelerator.org/appcelerator_sdk/trunk/components/websdk/src/js/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
compiler.js View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 1
markluffel
15 years, 9 months ago (2008-08-27 01:24:13 UTC) #1
So, Alex was telling me about the code review process that his team does, and I
checked out this thing that Guido, the creator of Python wrote.

It seems pretty sane and usable thus far, though for contract work, we'd
probably want to deploy a different copy of the source (it's open) rather than
use the default deployment (which is public).

There's nothing particularly interesting about this patch, I just needed
something to upload and had it outstanding.

Opinions on code review?

http://codereview.appspot.com/3275/diff/1/2
File compiler.js (right):

http://codereview.appspot.com/3275/diff/1/2#newcode2721
Line 2721: return [{key:str,value:'',empty:true}];
empty strings evaluate to false, don't we want a value that will be true (to
indicate that there was a key of that name (since presumably, keys without
values are either boolean flags or special strings for which the value doesn't
matter at all))?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b