Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(974)

Issue 326960043: [Enhancement] Add '-dcrop' option to ps and svg backends (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 3 days ago by pkx166h
Modified:
4 days, 6 hours ago
Reviewers:
Ebe123, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5165 This change allows the output of scores in the format provided by the '-dpreview' option but including all systems, not just the first. This would allow for easier SVG use in HTML, without the need for cropping snippets. Further, SVG is an HTML standard, and its vector nature makes its use unparalleled for the web. This change would allow SVG use in 'lilypond-book' in the future.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Implementation '-dcrop' argument was added to 'ps' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M Documentation/usage/running.itely View 1 2 chunks +5 lines, -1 line 0 comments Download
M lily/paper-book.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 1 1 chunk +16 lines, -0 lines 0 comments Download
M scm/framework-svg.scm View 1 1 chunk +8 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
pkx166h
Please note that *i* did the commit message - trying to interpret what Etienne is ...
3 weeks, 3 days ago (2017-07-27 07:21:12 UTC) #1
pkx166h
I am going to leave this on review for this countdown only that the submitter ...
2 weeks, 5 days ago (2017-08-01 08:13:37 UTC) #2
Carl
I have listed some specific changes that must be made (move to the proper alphabetical ...
2 weeks, 5 days ago (2017-08-01 12:22:03 UTC) #3
Carl
Oh, now I read the first message and see that the code doesn't work. My ...
2 weeks, 5 days ago (2017-08-01 12:25:09 UTC) #4
Ebe123
In PS2, an implementation of the '-dcrop' argument was added to the 'ps' backend. My ...
2 weeks, 2 days ago (2017-08-04 02:52:25 UTC) #5
pkx166h
Implementation '-dcrop' argument was added to 'ps'
2 weeks, 2 days ago (2017-08-04 09:32:10 UTC) #6
Ebe123
Add '-dcrop' option to ps and svg backends This change allows the output of scores ...
2 weeks, 1 day ago (2017-08-04 14:39:38 UTC) #7
pkx166h
1 week, 2 days ago (2017-08-11 13:08:18 UTC) #8
One thing I think we need is an entry in the changes.tely for this new feature.

Also now that you have tracker access (and because I cannot reassign this
Rietveld issue to someone), could you Etienne create a new Rietveld issue for
the tracker (which is now assigned to you) when you make the edit to the
changes.tely? 

Then we can discard this one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted