Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4000)

Issue 326510043: Issue 5187 Add command for Thin Aiken noteheads (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Karlin High
Modified:
2 years, 5 months ago
Reviewers:
pkx166h, carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5187 Add command for Thin Aiken noteheads Added 2 shapeNoteStyles definitions, aikenThinHeads and aikenThinHeadsMinor. Previously, these "thin-variant" Aiken notehead styles were not accessible in the same way as others. The standard aikenHeads are better for matching historical music, while these thin-variants are more readable at lower staff sizes. This is due to the standard Aiken heads having heavier horizontal lines, which sometimes leave little interior white space for distinguising white notes from black ones.

Patch Set 1 : Re-sending 2 patches, combined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Documentation/notation/pitches.itely View 5 chunks +8 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9
Karlin High
This is my first effort at making a patch, so I could be doing things ...
2 years, 6 months ago (2017-09-20 17:37:28 UTC) #1
Carl
This change to property-init.ly looks good. But the documentation (Shape Note Heads, in NR 1.1.4 ...
2 years, 6 months ago (2017-09-20 17:48:57 UTC) #2
Karlin High
On 2017/09/20 17:48:57, Carl wrote: > the documentation (Shape Note Heads, in NR 1.1.4 should ...
2 years, 6 months ago (2017-09-20 18:02:36 UTC) #3
Karlin High
> On 2017/09/20 17:48:57, Carl wrote: > the documentation (Shape Note Heads, in NR 1.1.4 ...
2 years, 6 months ago (2017-09-20 23:38:35 UTC) #4
pkx166h
On 2017/09/20 23:38:35, karlinhigh wrote: > > On 2017/09/20 17:48:57, Carl wrote: > > the ...
2 years, 6 months ago (2017-09-21 13:58:13 UTC) #5
Carl
On 2017/09/20 23:38:35, karlinhigh wrote: > > On 2017/09/20 17:48:57, Carl wrote: > > the ...
2 years, 6 months ago (2017-09-21 14:28:24 UTC) #6
Karlin High
My git-cl education continues. The intention here was uploading a patch for pitches.itely only, but ...
2 years, 6 months ago (2017-09-22 19:10:10 UTC) #7
Karlin High
Re-sending 2 patches, combined
2 years, 6 months ago (2017-09-22 22:12:27 UTC) #8
Carl
2 years, 6 months ago (2017-09-27 10:46:19 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b