Issue 325810043: [dftimewolf] Add Yapf config, reformat with yapf.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 325810043: [dftimewolf] Add Yapf config, reformat with yapf. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 11 months ago by onager

Modified:
6 years, 10 months ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, someguyiknow, tomchop

Visibility:
Public.

More Reviews

Description

[dftimewolf] Add Yapf config, reformat with yapf.

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -47 lines)			Patch
A	.style.yapf	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dftimewolf/timewolf_cli.py	View	2 chunks	+21 lines, -22 lines	0 comments	Download
M	dftimewolf/timewolf_collect.py	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	dftimewolf/timewolf_export.py	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	dftimewolf/timewolf_process.py	View	3 chunks	+8 lines, -10 lines	0 comments	Download
M	run_tests.py	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

onager

6 years, 10 months ago (2017-06-06 18:10:57 UTC) #3

On 2017/06/06 08:38:51, jberggren wrote:
> On 2017/06/01 23:09:25, onager wrote:
> 
> LGTM

Merging manually, given https://codereview.appspot.com/316710043/ is still
pending.

Expand All Messages | Collapse All Messages