Issue 32550043: Split out implementation specific behaviour

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 32550043: Split out implementation specific behaviour

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by dave

Modified:
10 years, 5 months ago

Reviewers:
mp+196643, axw

Visibility:
Public.

Description

Split out implementation specific behaviour Use conditional compilation rather than switching on runtime.Compiler. When the upstream bugs are resolved, we can remove these hacks. https://code.launchpad.net/~dave-cheney/goose/001-move-gccgo-specific-code-to-individual/+merge/196643 Requires: https://code.launchpad.net/~dave-cheney/goose/goose/+merge/196471 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -46 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	testservices/hook/service.go	View	2 chunks	+0 lines, -46 lines	0 comments	Download
A	testservices/hook/service_gc.go	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	testservices/hook/service_gccgo.go	View	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

10 years, 5 months ago (2013-11-26 03:54:57 UTC) #2

On 2013/11/26 01:32:05, dfc wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages