Issue 3251041: argparse FileType raises ugly exception for missing file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3251041: argparse FileType raises ugly exception for missing file

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by akira

Modified:
13 years, 4 months ago

Reviewers:
michael.mischurow, merwok

CC:
akira

Base URL:
http://svn.python.org/projects/python/branches/py3k/

Visibility:
Public.

Patch Set 2 : added tests for readonly files; raise ValueError in FileType.call #

Total comments: 7

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
	M	Lib/argparse.py	View	1	2 chunks	+11 lines, -6 lines	3 comments	Download
	M	Lib/test/test_argparse.py	View	1	3 chunks	+16 lines, -2 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

merwok

Some comments about style. I don’t know the argparse test machinery very well, but the ...

13 years, 4 months ago (2010-11-25 11:28:05 UTC) #1

SilentGhost

http://codereview.appspot.com/3251041/diff/2001/Lib/argparse.py File Lib/argparse.py (right): http://codereview.appspot.com/3251041/diff/2001/Lib/argparse.py#newcode1134 Lib/argparse.py:1134: err = _sys.exc_info()[1] On 2010/11/25 11:28:06, merwok wrote: > ...

13 years, 4 months ago (2010-11-25 11:52:32 UTC) #2

SilentGhost

13 years, 4 months ago (2010-11-25 13:46:37 UTC) #3

updated patch attached to bug http://bugs.python.org/issue9509

http://codereview.appspot.com/3251041/diff/2001/Lib/test/test_argparse.py
File Lib/test/test_argparse.py (right):

http://codereview.appspot.com/3251041/diff/2001/Lib/test/test_argparse.py#new...
Lib/test/test_argparse.py:58: file = open(file_path, 'w')
On 2010/11/25 11:28:06, merwok wrote:
> Please use a with statement.

Done.

http://codereview.appspot.com/3251041/diff/2001/Lib/test/test_argparse.py#new...
Lib/test/test_argparse.py:61: import stat
On 2010/11/25 11:28:06, merwok wrote:
> Please avoid imports at the function level.

Done.

Expand All Messages | Collapse All Messages