Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 325070043: Centering bass figures on whole notes and longer

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by pkx166h
Modified:
1 week, 4 days ago
Reviewers:
dak, thomasmorley651
CC:
lilypond-devel_gnu.org, richard_rshann.plus.com
Visibility:
Public.

Description

Centering bass figures on whole notes and longer This is a patch that fixes the centering of single bass figures over notes of duration whole note and more. The duration is tested and a translate applied horizontally if needed.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M scm/translation-functions.scm View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 15
thomasmorley651
I'm afraid this patch does not fix the problem as wished. See my comment on ...
1 week, 5 days ago (2017-07-15 07:09:03 UTC) #1
richard_rshann.plus.com
On Sat, 2017-07-15 at 00:09 -0700, thomasmorley65@gmail.com wrote: > I'm afraid this patch does not ...
1 week, 5 days ago (2017-07-15 07:25:37 UTC) #2
thomasmorley651
On 2017/07/15 07:25:37, richard_rshann.plus.com wrote: > On Sat, 2017-07-15 at 00:09 -0700, mailto:thomasmorley65@gmail.com wrote: > ...
1 week, 5 days ago (2017-07-15 07:40:01 UTC) #3
thomasmorley651
On 2017/07/15 07:40:01, thomasmorley651 wrote: > On 2017/07/15 07:25:37, http://richard_rshann.plus.com wrote: > > On Sat, ...
1 week, 5 days ago (2017-07-15 07:51:11 UTC) #4
dak
On 2017/07/15 07:51:11, thomasmorley651 wrote: > On 2017/07/15 07:40:01, thomasmorley651 wrote: > > > > ...
1 week, 5 days ago (2017-07-15 07:53:36 UTC) #5
richard_rshann.plus.com
On Sat, 2017-07-15 at 00:40 -0700, thomasmorley65@gmail.com wrote: > On 2017/07/15 07:25:37, richard_rshann.plus.com wrote: > ...
1 week, 5 days ago (2017-07-15 08:06:41 UTC) #6
thomasmorley651
On 2017/07/15 08:06:41, richard_rshann.plus.com wrote: > So I think you could validly object that you ...
1 week, 5 days ago (2017-07-15 08:50:52 UTC) #7
richard_rshann.plus.com
On Sat, 2017-07-15 at 08:51 +0100, Richard Shann wrote: > On Sat, 2017-07-15 at 00:40 ...
1 week, 5 days ago (2017-07-15 08:55:43 UTC) #8
richard_rshann.plus.com
On Sat, 2017-07-15 at 01:50 -0700, thomasmorley65@gmail.com wrote: > On 2017/07/15 08:06:41, richard_rshann.plus.com wrote: > ...
1 week, 5 days ago (2017-07-15 09:03:30 UTC) #9
thomasmorley651
On 2017/07/15 08:55:43, richard_rshann.plus.com wrote: > On Sat, 2017-07-15 at 08:51 +0100, Richard Shann wrote: ...
1 week, 5 days ago (2017-07-15 09:09:58 UTC) #10
thomasmorley651
On 2017/07/15 09:03:30, richard_rshann.plus.com wrote: > On Sat, 2017-07-15 at 01:50 -0700, mailto:thomasmorley65@gmail.com wrote: > ...
1 week, 5 days ago (2017-07-15 09:13:08 UTC) #11
richard_rshann.plus.com
On Sat, 2017-07-15 at 02:09 -0700, thomasmorley65@gmail.com wrote: > On 2017/07/15 08:55:43, richard_rshann.plus.com wrote: > ...
1 week, 5 days ago (2017-07-15 09:46:08 UTC) #12
thomasmorley651
On 2017/07/15 09:13:08, thomasmorley651 wrote: > If you try > \override BassFigure.X-offset = > #ly:self-alignment-interface::centered-on-x-parent ...
1 week, 5 days ago (2017-07-15 23:15:16 UTC) #13
richard_rshann.plus.com
On Sat, 2017-07-15 at 16:15 -0700, thomasmorley65@gmail.com wrote: > On 2017/07/15 09:13:08, thomasmorley651 wrote: > ...
1 week, 4 days ago (2017-07-16 09:25:24 UTC) #14
richard_rshann.plus.com
1 week, 4 days ago (2017-07-16 09:30:00 UTC) #15
On Sun, 2017-07-16 at 10:09 +0100, Richard Shann wrote:
> which shows them centering the figure under a whole note

well, actually, *over* a whole note inthis case. The fact that the whole
note is so far away from the figure (because of its pitch) makes the
effect still more subtle, it becomes more obvious if the figure is right
above/below the note.

Richard


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted