Issue 325050043: [plaso] Added event data support to ZIP and GZIP storage

Issue 325050043: [plaso] Added event data support to ZIP and GZIP storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 9 months ago by Joachim Metz

Modified:
6 years, 8 months ago

Reviewers:
onager

CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp, romaing

Visibility:
Public.

More Reviews

Description

[plaso] Added event data support to ZIP and GZIP storage

Patch Set 1 : Added event data support to ZIP and GZIP storage #

Total comments: 5

Patch Set 2 : Changes after merge #

Patch Set 3 : Changes after merge #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1126 lines, -1027 lines)			Patch
M	plaso/containers/events.py	View		4 chunks	+25 lines, -5 lines	0 comments	Download
M	plaso/containers/interface.py	View		2 chunks	+24 lines, -0 lines	0 comments	Download
A	plaso/storage/event_heaps.py	View	1	1 chunk	+160 lines, -0 lines	0 comments	Download
M	plaso/storage/fake_storage.py	View	1	3 chunks	+4 lines, -63 lines	0 comments	Download
M	plaso/storage/gzip_file.py	View	1	19 chunks	+139 lines, -22 lines	0 comments	Download
M	plaso/storage/identifiers.py	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	plaso/storage/interface.py	View	1	5 chunks	+78 lines, -21 lines	0 comments	Download
M	plaso/storage/sqlite_file.py	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download
M	plaso/storage/zip_file.py	View	1	72 chunks	+520 lines, -681 lines	0 comments	Download
M	tests/containers/interface.py	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/storage/fake_storage.py	View		2 chunks	+0 lines, -23 lines	0 comments	Download
M	tests/storage/gzip_file.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/storage/zip_file.py	View	1	14 chunks	+114 lines, -212 lines	0 comments	Download

Messages

Total messages: 15

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py File plaso/storage/event_heaps.py (right): https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py#newcode104 plaso/storage/event_heaps.py:104: def PopEvent(self): I'm not sure this class should inherit ...

6 years, 9 months ago (2017-07-12 19:05:25 UTC) #9

Joachim Metz

6 years, 8 months ago (2017-08-05 05:23:31 UTC) #10

onager

https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py File plaso/storage/event_heaps.py (right): https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py#newcode105 plaso/storage/event_heaps.py:105: """Retrieves and removes the first event from the heap. ...

6 years, 8 months ago (2017-08-12 10:23:39 UTC) #11

Joachim Metz

6 years, 8 months ago (2017-08-19 12:55:08 UTC) #15

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close storage8

Expand All Messages | Collapse All Messages