Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 325050043: [plaso] Added event data support to ZIP and GZIP storage

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by Joachim Metz
Modified:
2 weeks, 1 day ago
Reviewers:
onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp, romaing
Visibility:
Public.

Description

[plaso] Added event data support to ZIP and GZIP storage Depends on: https://codereview.appspot.com/326850043/ https://codereview.appspot.com/322270043/ https://codereview.appspot.com/327960043/

Patch Set 1 : Added event data support to ZIP and GZIP storage #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1094 lines, -1025 lines) Patch
M plaso/containers/events.py View 4 chunks +25 lines, -5 lines 0 comments Download
M plaso/containers/interface.py View 2 chunks +24 lines, -0 lines 0 comments Download
A plaso/storage/event_heaps.py View 1 chunk +130 lines, -0 lines 2 comments Download
M plaso/storage/fake_storage.py View 3 chunks +4 lines, -63 lines 0 comments Download
M plaso/storage/gzip_file.py View 18 chunks +138 lines, -22 lines 0 comments Download
M plaso/storage/identifiers.py View 1 chunk +26 lines, -0 lines 0 comments Download
M plaso/storage/interface.py View 5 chunks +78 lines, -21 lines 0 comments Download
M plaso/storage/sqlite_file.py View 1 chunk +19 lines, -0 lines 0 comments Download
M plaso/storage/zip_file.py View 72 chunks +521 lines, -677 lines 0 comments Download
M test_data/end_to_end/json.log View 1 chunk +2 lines, -2 lines 0 comments Download
M test_data/end_to_end/json_line.log View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/containers/interface.py View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/storage/fake_storage.py View 2 chunks +0 lines, -23 lines 0 comments Download
M tests/storage/gzip_file.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/storage/zip_file.py View 12 chunks +109 lines, -210 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
2 weeks, 5 days ago (2017-07-08 20:57:33 UTC) #1
Joachim Metz
Code updated.
2 weeks, 5 days ago (2017-07-08 21:31:31 UTC) #2
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-07-09 04:10:38 UTC) #3
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-07-09 05:13:57 UTC) #4
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-07-09 09:59:52 UTC) #5
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-07-09 10:09:04 UTC) #6
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-07-09 10:42:24 UTC) #7
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-07-09 12:28:19 UTC) #8
onager
2 weeks, 1 day ago (2017-07-12 19:05:25 UTC) #9
https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heap...
File plaso/storage/event_heaps.py (right):

https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heap...
plaso/storage/event_heaps.py:104: def PopEvent(self):
I'm not sure this class should inherit from BaseEventHeap. It breaks PopEvents,
which now returns tuples instead of events.

Change the base class for this.

https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heap...
plaso/storage/event_heaps.py:105: """Retrieves and removes the first event from
the heap.
It returns the event, and its stream
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted