Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(545)

Issue 325050043: [plaso] Added event data support to ZIP and GZIP storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by Joachim Metz
Modified:
1 month ago
Reviewers:
onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp, romaing
Visibility:
Public.

Description

[plaso] Added event data support to ZIP and GZIP storage

Patch Set 1 : Added event data support to ZIP and GZIP storage #

Total comments: 5

Patch Set 2 : Changes after merge #

Patch Set 3 : Changes after merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1126 lines, -1027 lines) Patch
M plaso/containers/events.py View 4 chunks +25 lines, -5 lines 0 comments Download
M plaso/containers/interface.py View 2 chunks +24 lines, -0 lines 0 comments Download
A plaso/storage/event_heaps.py View 1 1 chunk +160 lines, -0 lines 0 comments Download
M plaso/storage/fake_storage.py View 1 3 chunks +4 lines, -63 lines 0 comments Download
M plaso/storage/gzip_file.py View 1 19 chunks +139 lines, -22 lines 0 comments Download
M plaso/storage/identifiers.py View 1 chunk +26 lines, -0 lines 0 comments Download
M plaso/storage/interface.py View 1 5 chunks +78 lines, -21 lines 0 comments Download
M plaso/storage/sqlite_file.py View 1 2 chunks +20 lines, -0 lines 0 comments Download
M plaso/storage/zip_file.py View 1 72 chunks +520 lines, -681 lines 0 comments Download
M tests/containers/interface.py View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/storage/fake_storage.py View 2 chunks +0 lines, -23 lines 0 comments Download
M tests/storage/gzip_file.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/storage/zip_file.py View 1 14 chunks +114 lines, -212 lines 0 comments Download

Messages

Total messages: 15
Joachim Metz
2 months, 2 weeks ago (2017-07-08 20:57:33 UTC) #1
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-08 21:31:31 UTC) #2
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-09 04:10:38 UTC) #3
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-09 05:13:57 UTC) #4
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-09 09:59:52 UTC) #5
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-09 10:09:04 UTC) #6
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-09 10:42:24 UTC) #7
Joachim Metz
Code updated.
2 months, 2 weeks ago (2017-07-09 12:28:19 UTC) #8
onager
https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py File plaso/storage/event_heaps.py (right): https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py#newcode104 plaso/storage/event_heaps.py:104: def PopEvent(self): I'm not sure this class should inherit ...
2 months, 1 week ago (2017-07-12 19:05:25 UTC) #9
Joachim Metz
https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py File plaso/storage/event_heaps.py (right): https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py#newcode104 plaso/storage/event_heaps.py:104: def PopEvent(self): On 2017/07/12 19:05:25, onager wrote: > I'm ...
1 month, 2 weeks ago (2017-08-05 05:23:31 UTC) #10
onager
https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py File plaso/storage/event_heaps.py (right): https://codereview.appspot.com/325050043/diff/140001/plaso/storage/event_heaps.py#newcode105 plaso/storage/event_heaps.py:105: """Retrieves and removes the first event from the heap. ...
1 month, 1 week ago (2017-08-12 10:23:39 UTC) #11
Joachim Metz
Code updated.
1 month, 1 week ago (2017-08-14 05:49:19 UTC) #12
Joachim Metz
Code updated.
1 month ago (2017-08-16 19:13:11 UTC) #13
onager
LGTM
1 month ago (2017-08-18 12:27:59 UTC) #14
Joachim Metz
1 month ago (2017-08-19 12:55:08 UTC) #15
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close storage8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted