Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 324780043: Fix not scaling stem in note-by-number-markup

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by thomasmorley651
Modified:
6 months ago
Reviewers:
david.nalesnik
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix not scaling stem in note-by-number-markup Done by calling text-font-size from layout, which defaults to 11. Then scaling stem-thickness and stem-length by division of text-font-size through 11. This ensures a stem-appearance according to the text-properties of MetronomeMark.

Patch Set 1 #

Patch Set 2 : give text-font-size a fallback-value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M scm/define-markup-commands.scm View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3
thomasmorley651
Please review.
6 months, 1 week ago (2017-04-16 17:17:48 UTC) #1
thomasmorley651
give text-font-size a fallback-value
6 months, 1 week ago (2017-04-16 19:15:37 UTC) #2
david.nalesnik
6 months ago (2017-04-20 15:12:32 UTC) #3
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted