Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 324740043: Add scriptExceptions property/convenience functions

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by david.nalesnik
Modified:
7 years ago
Reviewers:
pkx166h, dak, carl_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add scriptExceptions property/convenience functions These is currently no convenient way to change default settings for a specific articulation-type. -- This commit adds a new context property, scriptExceptions, which holds custom user settings to modify the default scriptDefinitions. The data structure is modeled after scriptDefinitions and the public variable default-script-alist. The settings in scriptExceptions are simply added to the head of the property-value alists of the indicated scripts. New settings will be used by virtue of appearing before the default settings, and there is no need to include settings of untouched properties because the defaults are still present. -- Add two convenience functions for easily modifying settings for a single articulation type: \addScriptExceptions and \removeScriptExceptions -- Add two regtests and a Changes entry.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -0 lines) Patch
M Documentation/changes.tely View 1 chunk +41 lines, -0 lines 0 comments Download
A input/regression/script-exceptions.ly View 1 chunk +37 lines, -0 lines 0 comments Download
A input/regression/script-exceptions-adding-removing.ly View 1 chunk +36 lines, -0 lines 0 comments Download
M lily/script-engraver.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 2 chunks +56 lines, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
david.nalesnik
I've noticed that setting some properties with this patch doesn't have an effect: for example, ...
7 years ago (2017-04-05 00:55:51 UTC) #1
carl_sorensen
LGTM. THis looks like a real handy tool for creating style sheets. Thanks, Carl
7 years ago (2017-04-05 03:51:02 UTC) #2
pkx166h
Do you want this tested? I cannot see any tracker issue for this. Or is ...
7 years ago (2017-04-05 15:47:19 UTC) #3
david.nalesnik
On 2017/04/05 15:47:19, pkx166h wrote: > Do you want this tested? > > I cannot ...
7 years ago (2017-04-05 15:55:38 UTC) #4
dak
On 2017/04/05 15:55:38, david.nalesnik wrote: > On 2017/04/05 15:47:19, pkx166h wrote: > > Do you ...
7 years ago (2017-04-07 17:30:25 UTC) #5
david.nalesnik
On 2017/04/07 17:30:25, dak wrote: > On 2017/04/05 15:55:38, david.nalesnik wrote: > > On 2017/04/05 ...
7 years ago (2017-04-07 18:27:25 UTC) #6
dak
7 years ago (2017-04-07 18:55:15 UTC) #7
On 2017/04/07 18:27:25, david.nalesnik wrote:

> I see no way to make a context property holding exceptions work with the
system
> in place.  (Which is why I set the patch to needs work.)
> 
> I'll work on putting an override system in place.

Ugh.  I actually don't have all that good of an idea just which override should
override what in what situation.  The user will likely expect his last override
to make a difference, but when expections and base grob are in different data
structures, "last" cannot be determined.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b