Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 323850043: Initial work to support opentype font features

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by horndude77
Modified:
2 months ago
Reviewers:
pkx166h, trueroad
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Initial work to support opentype font features Following up on an old patch I send to the list. One comment was to use a list for combining multiple font features. This is now implemented. A possible issue is the pango API needed is somewhat newer. I'll investigate where I need to set that in an update (pointers and hints welcome).

Patch Set 1 #

Patch Set 2 : Update minimum pango version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -10 lines) Patch
M configure.ac View 1 1 chunk +1 line, -1 line 0 comments Download
A input/regression/font-features.ly View 1 chunk +22 lines, -0 lines 0 comments Download
M lily/font-interface.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lily/font-metric.cc View 1 chunk +3 lines, -1 line 0 comments Download
M lily/include/font-metric.hh View 1 chunk +3 lines, -1 line 0 comments Download
M lily/include/modified-font-metric.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/pango-font.hh View 1 chunk +3 lines, -1 line 0 comments Download
M lily/modified-font-metric.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M lily/pango-font.cc View 2 chunks +13 lines, -1 line 0 comments Download
M lily/text-interface.cc View 1 chunk +37 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
pkx166h
This has reached the push stage in the patch countdown - although you may need ...
2 months, 3 weeks ago (2017-05-30 18:58:35 UTC) #1
horndude77
Update minimum pango version
2 months, 2 weeks ago (2017-06-05 05:01:28 UTC) #2
trueroad
On 2017/06/05 05:01:28, horndude77 wrote: > Update minimum pango version If I understand correctly, LilyDev ...
2 months, 1 week ago (2017-06-12 10:43:53 UTC) #3
trueroad
On 2017/06/12 10:43:53, trueroad wrote: > On 2017/06/05 05:01:28, horndude77 wrote: > > Update minimum ...
2 months, 1 week ago (2017-06-13 12:25:22 UTC) #4
trueroad
2 months ago (2017-06-19 15:03:22 UTC) #5
I've pushed to staging.

commit 8cf69a467ad7650f5ca9da6fe2dfd4c7c088b239
Issue 1388: Initial work to support opentype font features.

Thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted