Issue 323450043: Doc: Issue 4993 Different time signatures in alternative repeats

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 323450043: Doc: Issue 4993 Different time signatures in alternative repeats

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by Trevor Daniels

Modified:
6 years, 8 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Doc: Issue 4993 Different time signatures in alternative repeats Add warning to NR about alternatives starting with different time signatures.

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Documentation/notation/repeats.itely	View		1 chunk	+6 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dak

6 years, 8 months ago (2017-08-20 09:56:56 UTC) #1

https://codereview.appspot.com/323450043/diff/1/Documentation/notation/repeat...
File Documentation/notation/repeats.itely (right):

https://codereview.appspot.com/323450043/diff/1/Documentation/notation/repeat...
Documentation/notation/repeats.itely:172: @warning{If there are two or more
alternatives it is assumed that
No, this is completely wrong.  The "assumption" (or rather, bug) is that the
_first_ alternative should not immediately start by changing one of the recorded
properties or things might go awry.

I'll try to see whether it is reasonably possible to fix that bug.  As it
stands, alternativeRestores are sort-of half-baked, and it turns out that even
their half-bakedness gets stuff wrong.

Expand All Messages | Collapse All Messages