Issue 323400043: ticket:13274 Break Iterator Test, cleanups & Java porting.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 323400043: ticket:13274 Break Iterator Test, cleanups & Java porting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by andy.heninger

Modified:
6 years, 8 months ago

Reviewers:
nrunge

Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/

Visibility:
Public.

More Reviews

Description

Move some updated tests from RBBI development branch (ICU4C) and port to Java.

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+353 lines, -199 lines)			Patch
M	.	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	icu4c	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	icu4c/source	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	icu4c/source/test	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	icu4c/source/test/intltest	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	icu4c/source/test/intltest/rbbiapts.cpp	View	19 chunks	+45 lines, -45 lines	0 comments	Download
M	icu4c/source/test/intltest/rbbitst.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	icu4c/source/test/intltest/rbbitst.cpp	View	25 chunks	+116 lines, -107 lines	1 comment	Download
M	icu4c/source/test/testdata/rbbitst.txt	View	3 chunks	+59 lines, -3 lines	0 comments	Download
M	icu4j	View	0 chunks	+0 lines, -0 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestExtended.java	View	15 chunks	+74 lines, -36 lines	1 comment	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/rbbitst.txt	View	3 chunks	+59 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nrunge

On 2017/08/08 21:01:01, andy.heninger wrote: > Set Norbert as reviewer. Please add a more informative ...

6 years, 8 months ago (2017-08-15 21:24:52 UTC) #2

nrunge

Again ... https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rbbitst.cpp File icu4c/source/test/intltest/rbbitst.cpp (right): https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rbbitst.cpp#newcode1467 icu4c/source/test/intltest/rbbitst.cpp:1467: // within a block that should have ...

6 years, 8 months ago (2017-08-16 23:22:48 UTC) #3

nrunge

6 years, 8 months ago (2017-08-16 23:24:40 UTC) #4

On 2017/08/16 23:22:48, nrunge wrote:
> Again ...
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rb...
> File icu4c/source/test/intltest/rbbitst.cpp (right):
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rb...
> icu4c/source/test/intltest/rbbitst.cpp:1467: //   within a block that should
> have been terminated.
> Two blanks too many?
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4j/main/tests/core/src/com...
> File icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestExtended.java
> (right):
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4j/main/tests/core/src/com...
> icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestExtended.java:405:
> //   within a block that should have been terminated.
> Two blanks too many?

LGTM

Expand All Messages | Collapse All Messages