Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(625)

Issue 323400043: ticket:13274 Break Iterator Test, cleanups & Java porting. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by andy.heninger
Modified:
2 months ago
Reviewers:
nrunge
Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

Move some updated tests from RBBI development branch (ICU4C) and port to Java.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -199 lines) Patch
M . View 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c View 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c/source View 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c/source/test View 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest View 0 chunks +0 lines, -0 lines 0 comments Download
M icu4c/source/test/intltest/rbbiapts.cpp View 19 chunks +45 lines, -45 lines 0 comments Download
M icu4c/source/test/intltest/rbbitst.h View 1 chunk +0 lines, -5 lines 0 comments Download
M icu4c/source/test/intltest/rbbitst.cpp View 25 chunks +116 lines, -107 lines 1 comment Download
M icu4c/source/test/testdata/rbbitst.txt View 3 chunks +59 lines, -3 lines 0 comments Download
M icu4j View 0 chunks +0 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestExtended.java View 15 chunks +74 lines, -36 lines 1 comment Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/rbbitst.txt View 3 chunks +59 lines, -3 lines 0 comments Download

Messages

Total messages: 4
andy.heninger
Set Norbert as reviewer.
2 months, 1 week ago (2017-08-08 21:01:01 UTC) #1
nrunge
On 2017/08/08 21:01:01, andy.heninger wrote: > Set Norbert as reviewer. Please add a more informative ...
2 months ago (2017-08-15 21:24:52 UTC) #2
nrunge
Again ... https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rbbitst.cpp File icu4c/source/test/intltest/rbbitst.cpp (right): https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rbbitst.cpp#newcode1467 icu4c/source/test/intltest/rbbitst.cpp:1467: // within a block that should have ...
2 months ago (2017-08-16 23:22:48 UTC) #3
nrunge
2 months ago (2017-08-16 23:24:40 UTC) #4
On 2017/08/16 23:22:48, nrunge wrote:
> Again ...
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rb...
> File icu4c/source/test/intltest/rbbitst.cpp (right):
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4c/source/test/intltest/rb...
> icu4c/source/test/intltest/rbbitst.cpp:1467: //   within a block that should
> have been terminated.
> Two blanks too many?
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4j/main/tests/core/src/com...
> File icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestExtended.java
> (right):
> 
>
https://codereview.appspot.com/323400043/diff/1/icu4j/main/tests/core/src/com...
> icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITestExtended.java:405:
> //   within a block that should have been terminated.
> Two blanks too many?

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted