Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4385)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 323180043: [dfvfs] Changes to replace stat with attributes #52 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by Joachim Metz
Modified:
6 years, 9 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Changes to replace stat with attributes #52

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1373 lines, -682 lines) Patch
M dfvfs/vfs/bde_file_entry.py View 1 1 chunk +33 lines, -25 lines 0 comments Download
M dfvfs/vfs/bde_file_system.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/fake_file_system.py View 10 chunks +21 lines, -22 lines 0 comments Download
M dfvfs/vfs/file_entry.py View 11 chunks +239 lines, -122 lines 0 comments Download
M dfvfs/vfs/file_system.py View 1 11 chunks +45 lines, -33 lines 0 comments Download
M dfvfs/vfs/ntfs_file_entry.py View 21 chunks +92 lines, -168 lines 0 comments Download
M dfvfs/vfs/ntfs_file_system.py View 3 chunks +27 lines, -6 lines 0 comments Download
M dfvfs/vfs/root_only_file_entry.py View 1 chunk +6 lines, -17 lines 0 comments Download
M dfvfs/vfs/tar_file_entry.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M dfvfs/vfs/tsk_file_entry.py View 7 chunks +10 lines, -10 lines 0 comments Download
M dfvfs/vfs/vshadow_file_entry.py View 7 chunks +48 lines, -66 lines 0 comments Download
M dfvfs/vfs/vshadow_file_system.py View 5 chunks +26 lines, -13 lines 0 comments Download
M dfvfs/vfs/zip_file_entry.py View 1 8 chunks +70 lines, -78 lines 0 comments Download
M dfvfs/vfs/zip_file_system.py View 1 5 chunks +35 lines, -13 lines 0 comments Download
M tests/vfs/bde_file_entry.py View 2 chunks +62 lines, -6 lines 0 comments Download
M tests/vfs/compressed_stream_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/cpio_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/data_range_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/encoded_stream_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/encrypted_stream_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/fake_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
A tests/vfs/file_entry.py View 1 chunk +140 lines, -0 lines 0 comments Download
M tests/vfs/file_system.py View 2 chunks +13 lines, -1 line 0 comments Download
M tests/vfs/fvde_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/gzip_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/lvm_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/ntfs_file_entry.py View 5 chunks +263 lines, -22 lines 0 comments Download
M tests/vfs/ntfs_file_system.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/vfs/os_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/os_file_system.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/sqlite_blob_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/tar_file_entry.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/tsk_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/tsk_partition_file_entry.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/vshadow_file_entry.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/vfs/vshadow_file_system.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/vfs/zip_file_entry.py View 1 4 chunks +215 lines, -59 lines 0 comments Download
M tests/vfs/zip_file_system.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
6 years, 10 months ago (2017-06-25 18:24:15 UTC) #1
onager
https://codereview.appspot.com/323180043/diff/1/dfvfs/vfs/bde_file_entry.py File dfvfs/vfs/bde_file_entry.py (right): https://codereview.appspot.com/323180043/diff/1/dfvfs/vfs/bde_file_entry.py#newcode31 dfvfs/vfs/bde_file_entry.py:31: entry emulated by the corresponding file system. Errant copy ...
6 years, 9 months ago (2017-07-04 13:48:09 UTC) #2
onager
https://codereview.appspot.com/323180043/diff/1/dfvfs/vfs/file_entry.py File dfvfs/vfs/file_entry.py (right): https://codereview.appspot.com/323180043/diff/1/dfvfs/vfs/file_entry.py#newcode164 dfvfs/vfs/file_entry.py:164: """Retrieves information about the file entry. Depending on your ...
6 years, 9 months ago (2017-07-04 13:50:05 UTC) #3
Joachim Metz
https://codereview.appspot.com/323180043/diff/1/dfvfs/vfs/bde_file_entry.py File dfvfs/vfs/bde_file_entry.py (right): https://codereview.appspot.com/323180043/diff/1/dfvfs/vfs/bde_file_entry.py#newcode31 dfvfs/vfs/bde_file_entry.py:31: entry emulated by the corresponding file system. On 2017/07/04 ...
6 years, 9 months ago (2017-07-04 17:26:28 UTC) #4
Joachim Metz
Code updated.
6 years, 9 months ago (2017-07-04 17:28:11 UTC) #5
onager
LGTM
6 years, 9 months ago (2017-07-05 08:42:49 UTC) #6
Joachim Metz
6 years, 9 months ago (2017-07-06 04:27:01 UTC) #7 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dfdatetime
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b