Issue 323040043: Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and conver…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 323040043: Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and conver…

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 11 months ago by chazwins6

Modified:
5 years, 4 months ago

Reviewers:
lilypond-pkx, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with.

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -16 lines)			Patch
M	ly/music-functions-init.ly	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ly/property-init.ly	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	python/convertrules.py	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	scm/define-context-properties.scm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scm/define-music-display-methods.scm	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	scm/define-music-properties.scm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scm/part-combiner.scm	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Trevor Daniels

Looks OK as far as it goes, but the Docs have been missed. Trevor

6 years, 11 months ago (2017-05-30 17:50:02 UTC) #1

lilypond-pkx

5 years, 4 months ago (2018-12-18 12:31:15 UTC) #2

On 2017/05/30 17:50:02, Trevor Daniels wrote:
> Looks OK as far as it goes, but the Docs have been missed.
> 
> Trevor

This has now been superceded by http://codereview.appspot.com/369930043

Expand All Messages | Collapse All Messages