Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(595)

Issue 322730043: trytond-gis: Initial commit

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by nicoe
Modified:
7 months, 2 weeks ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Total comments: 12

Patch Set 2 : Fix comments and move regexp #

Patch Set 3 : rename abstract_type and move regexp to prevent circular imports #

Patch Set 4 : Add forgotten database.py #

Patch Set 5 : Add forgotten database.py #

Total comments: 21

Patch Set 6 : Use setUpModule to populate the module list and register the testing module #

Patch Set 7 : create the postgis extension on the database creation #

Patch Set 8 : Use setuptools find_packages to find packages #

Patch Set 9 : Use geojson instead of dbgis #

Patch Set 10 : remove comment #

Total comments: 24

Patch Set 11 : Use geomet, add tests, move stuffs in cont.py and sql.py #

Total comments: 19

Patch Set 12 : Upload the fixed version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1143 lines, -0 lines) Patch
A COPYRIGHT View 1 2 3 4 5 6 7 8 1 chunk +15 lines, -0 lines 0 comments Download
A LICENSE View 1 2 3 4 5 6 7 8 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
A README View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +49 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 5 6 7 8 1 chunk +13 lines, -0 lines 0 comments Download
A trytond_gis/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +16 lines, -0 lines 0 comments Download
A trytond_gis/const.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +7 lines, -0 lines 0 comments Download
A trytond_gis/fields.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +81 lines, -0 lines 0 comments Download
A trytond_gis/postgis/__init__.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
A trytond_gis/postgis/database.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +61 lines, -0 lines 0 comments Download
A trytond_gis/postgis/table.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +72 lines, -0 lines 0 comments Download
A trytond_gis/sql.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +10 lines, -0 lines 0 comments Download
A trytond_gis/tests/__init__.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
A trytond_gis/tests/test_fields.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +106 lines, -0 lines 0 comments Download
A trytond_gis/tests/test_gis/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +11 lines, -0 lines 0 comments Download
A trytond_gis/tests/test_gis/gis.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 21
nicoe
1 year, 5 months ago (2017-03-17 13:53:08 UTC) #1
ced
https://codereview.appspot.com/322730043/diff/1/setup.py File setup.py (right): https://codereview.appspot.com/322730043/diff/1/setup.py#newcode10 setup.py:10: setup(name='trytond_gis', Maybe better: trytond_backend_gis https://codereview.appspot.com/322730043/diff/1/setup.py#newcode14 setup.py:14: url='http://trytond-gis.b2ck.com/', I'm wondering ...
1 year, 5 months ago (2017-03-17 14:36:10 UTC) #2
nicoe
https://codereview.appspot.com/322730043/diff/1/setup.py File setup.py (right): https://codereview.appspot.com/322730043/diff/1/setup.py#newcode10 setup.py:10: setup(name='trytond_gis', On 2017/03/17 14:36:10, ced wrote: > Maybe better: ...
1 year, 5 months ago (2017-03-20 17:19:42 UTC) #3
nicoe
Fix comments and move regexp
1 year, 5 months ago (2017-03-20 17:20:11 UTC) #4
nicoe
rename abstract_type and move regexp to prevent circular imports
1 year, 4 months ago (2017-03-23 16:25:36 UTC) #5
nicoe
Add forgotten database.py
1 year, 4 months ago (2017-03-23 16:41:51 UTC) #6
ced
https://codereview.appspot.com/322730043/diff/80001/setup.py File setup.py (right): https://codereview.appspot.com/322730043/diff/80001/setup.py#newcode16 setup.py:16: description='Adds GIS support to trytond', Maybe use: Geographical Information ...
1 year, 3 months ago (2017-05-19 16:23:25 UTC) #7
ced
I'm wondering if we should not use https://github.com/cleder/pygeoif as suggested by https://stackoverflow.com/questions/14940285/using-postgis-on-python-3
1 year, 3 months ago (2017-05-19 16:36:23 UTC) #8
nicoe
Use setUpModule to populate the module list and register the testing module
1 year, 1 month ago (2017-06-25 19:57:46 UTC) #9
nicoe
On 2017/05/19 16:36:23, ced wrote: > I'm wondering if we should not use https://github.com/cleder/pygeoif > ...
1 year, 1 month ago (2017-06-25 19:58:27 UTC) #10
nicoe
https://codereview.appspot.com/322730043/diff/80001/setup.py File setup.py (right): https://codereview.appspot.com/322730043/diff/80001/setup.py#newcode16 setup.py:16: description='Adds GIS support to trytond', On 2017/05/19 16:23:24, ced ...
1 year, 1 month ago (2017-06-25 19:58:37 UTC) #11
nicoe
create the postgis extension on the database creation
1 year, 1 month ago (2017-06-30 15:15:32 UTC) #12
nicoe
Use setuptools find_packages to find packages
1 year, 1 month ago (2017-06-30 16:40:26 UTC) #13
nicoe
Use geojson instead of dbgis
11 months, 1 week ago (2017-09-14 15:43:21 UTC) #14
nicoe
remove comment
11 months, 1 week ago (2017-09-14 16:53:56 UTC) #15
ced
https://codereview.appspot.com/322730043/diff/180001/README File README (right): https://codereview.appspot.com/322730043/diff/180001/README#newcode8 README:8: .. _flask_tryton bugtracker: http://trytond-gis.b2ck.com/ wrong name https://codereview.appspot.com/322730043/diff/180001/setup.py File setup.py ...
11 months, 1 week ago (2017-09-15 09:49:21 UTC) #16
nicoe
Use geomet, add tests, move stuffs in cont.py and sql.py
11 months ago (2017-09-18 09:33:10 UTC) #17
nicoe
https://codereview.appspot.com/322730043/diff/180001/README File README (right): https://codereview.appspot.com/322730043/diff/180001/README#newcode8 README:8: .. _flask_tryton bugtracker: http://trytond-gis.b2ck.com/ On 2017/09/15 09:49:20, ced wrote: ...
11 months ago (2017-09-19 10:14:10 UTC) #18
ced
https://codereview.appspot.com/322730043/diff/180001/setup.py File setup.py (right): https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode11 setup.py:11: setup(name='trytond_backend_gis', On 2017/09/19 10:14:05, nicoe wrote: > On 2017/09/15 ...
11 months ago (2017-09-20 17:28:21 UTC) #19
nicoe
Upload the fixed version
8 months, 2 weeks ago (2017-12-06 12:26:33 UTC) #20
ced
7 months, 2 weeks ago (2017-12-31 16:41:01 UTC) #21
Promoted as standard Tryton package at https://bugs.tryton.org/issue2919
https://codereview.tryton.org/43011002 includes drone test, fix test for new
geomet and work to be part of release process of Tryton.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b