trytond-gis: Initial commit

[ced, 2017-03-17 14:36:10]

https://codereview.appspot.com/322730043/diff/1/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/1/setup.py#newcode10
setup.py:10: setup(name='trytond_gis',
Maybe better: trytond_backend_gis

https://codereview.appspot.com/322730043/diff/1/setup.py#newcode14
setup.py:14: url='http://trytond-gis.b2ck.com/',
I'm wondering if we should not propose it to tryton.org

https://codereview.appspot.com/322730043/diff/1/setup.py#newcode27
setup.py:27: 'Programming Language :: Python :: 2.7',
We should support python3

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py
File trytond_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py#newcode1
trytond_gis/fields.py:1: # This file is part of tryton_gis.  The COPYRIGHT file
at the top level of
trytond_gis

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py#newcode19
trytond_gis/fields.py:19: loading=loading, help=help)
I'm wondering it is not better to use **kwargs to easily follow compatibility.

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py#newcode25
trytond_gis/fields.py:25: return 'GEOMETRY:%s(%s, %s)' % (
Should it not better to use 'GIS' as prefix?
Also is it not more SQL style to use '_' instead of ':'

[nicoe, 2017-03-20 17:19:42]

https://codereview.appspot.com/322730043/diff/1/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/1/setup.py#newcode10
setup.py:10: setup(name='trytond_gis',
On 2017/03/17 14:36:10, ced wrote:
> Maybe better: trytond_backend_gis

Done.

https://codereview.appspot.com/322730043/diff/1/setup.py#newcode14
setup.py:14: url='http://trytond-gis.b2ck.com/',
On 2017/03/17 14:36:10, ced wrote:
> I'm wondering if we should not propose it to http://tryton.org

I'll write and email about that on tryton-dev

https://codereview.appspot.com/322730043/diff/1/setup.py#newcode27
setup.py:27: 'Programming Language :: Python :: 2.7',
On 2017/03/17 14:36:10, ced wrote:
> We should support python3

Done.

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py
File trytond_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py#newcode1
trytond_gis/fields.py:1: # This file is part of tryton_gis.  The COPYRIGHT file
at the top level of
On 2017/03/17 14:36:10, ced wrote:
> trytond_gis

Done.

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py#newcode19
trytond_gis/fields.py:19: loading=loading, help=help)
On 2017/03/17 14:36:10, ced wrote:
> I'm wondering it is not better to use **kwargs to easily follow compatibility.

Done.

https://codereview.appspot.com/322730043/diff/1/trytond_gis/fields.py#newcode25
trytond_gis/fields.py:25: return 'GEOMETRY:%s(%s, %s)' % (
On 2017/03/17 14:36:10, ced wrote:
> Should it not better to use 'GIS' as prefix?
> Also is it not more SQL style to use '_' instead of ':'

Done.

[nicoe, 2017-03-20 17:20:11]

Fix comments and move regexp

[nicoe, 2017-03-23 16:25:36]

rename abstract_type and move regexp to prevent circular imports

[nicoe, 2017-03-23 16:41:51]

Add forgotten database.py

[ced, 2017-05-19 16:23:25]

https://codereview.appspot.com/322730043/diff/80001/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/80001/setup.py#newcode16
setup.py:16: description='Adds GIS support to trytond',
Maybe use: Geographical Information System

https://codereview.appspot.com/322730043/diff/80001/setup.py#newcode27
setup.py:27: 'Programming Language :: Python :: 2',
I do not know what this means? Which version?

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/__ini...
File trytond_backend_gis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/__ini...
trytond_backend_gis/__init__.py:3: # terms.
Usually we have only 2 lines.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/field...
File trytond_backend_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/field...
trytond_backend_gis/fields.py:13: if 'loading' not in kwargs:
Why not having loading defined in __init__ signature?

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/field...
trytond_backend_gis/fields.py:15: super(Geometry, self).__init__(**kwargs)
is it not possible to have: __init__(string=string, loading=loading, **kwargs)

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
File trytond_backend_gis/postgis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/__init__.py:2: DatabaseOperationalError)
You could import them in database and have from .database import *

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
File trytond_backend_gis/postgis/database.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/database.py:9: dbgis = None
I find it strange that it can work the same without dbgis.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/database.py:15: connection = super(Database,
self).get_connection(autocommit, readonly)
Use keyworded values, it is safer in case of change.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
File trytond_backend_gis/postgis/table.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/table.py:6: from trytond.backend.postgresql.table
import _NO_DEFAULT
Does not exist.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/table.py:8: from trytond_backend_gis import GIS_RE
Will it not be better to make a relative import?

Indeed I think it is used only here, so better to move it.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/table.py:15: def add_column(self, column_name,
abstract_type, default=_NO_DEFAULT,
default is None

[ced, 2017-05-19 16:36:23]

I'm wondering if we should not use https://github.com/cleder/pygeoif
as suggested by
https://stackoverflow.com/questions/14940285/using-postgis-on-python-3

[nicoe, 2017-06-25 19:57:46]

Use setUpModule to populate the module list and register the testing module

[nicoe, 2017-06-25 19:58:27]

On 2017/05/19 16:36:23, ced wrote:
> I'm wondering if we should not use https://github.com/cleder/pygeoif
> as suggested by
> https://stackoverflow.com/questions/14940285/using-postgis-on-python-3

It does not support srid but we could get rid of this problem by specifying the
srid in the configuration file I guess.

[nicoe, 2017-06-25 19:58:37]

https://codereview.appspot.com/322730043/diff/80001/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/80001/setup.py#newcode16
setup.py:16: description='Adds GIS support to trytond',
On 2017/05/19 16:23:24, ced wrote:
> Maybe use: Geographical Information System

Done.

https://codereview.appspot.com/322730043/diff/80001/setup.py#newcode27
setup.py:27: 'Programming Language :: Python :: 2',
On 2017/05/19 16:23:24, ced wrote:
> I do not know what this means? Which version?

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/__ini...
File trytond_backend_gis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/__ini...
trytond_backend_gis/__init__.py:3: # terms.
On 2017/05/19 16:23:24, ced wrote:
> Usually we have only 2 lines.

Usually module names are not that long.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/field...
File trytond_backend_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/field...
trytond_backend_gis/fields.py:13: if 'loading' not in kwargs:
On 2017/05/19 16:23:24, ced wrote:
> Why not having loading defined in __init__ signature?

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/field...
trytond_backend_gis/fields.py:15: super(Geometry, self).__init__(**kwargs)
On 2017/05/19 16:23:24, ced wrote:
> is it not possible to have: __init__(string=string, loading=loading, **kwargs)

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
File trytond_backend_gis/postgis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/__init__.py:2: DatabaseOperationalError)
On 2017/05/19 16:23:24, ced wrote:
> You could import them in database and have from .database import *

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
File trytond_backend_gis/postgis/database.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/database.py:15: connection = super(Database,
self).get_connection(autocommit, readonly)
On 2017/05/19 16:23:25, ced wrote:
> Use keyworded values, it is safer in case of change.

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
File trytond_backend_gis/postgis/table.py (right):

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/table.py:6: from trytond.backend.postgresql.table
import _NO_DEFAULT
On 2017/05/19 16:23:25, ced wrote:
> Does not exist.

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/table.py:8: from trytond_backend_gis import GIS_RE
On 2017/05/19 16:23:25, ced wrote:
> Will it not be better to make a relative import?
> 
> Indeed I think it is used only here, so better to move it.

Done.

https://codereview.appspot.com/322730043/diff/80001/trytond_backend_gis/postg...
trytond_backend_gis/postgis/table.py:15: def add_column(self, column_name,
abstract_type, default=_NO_DEFAULT,
On 2017/05/19 16:23:25, ced wrote:
> default is None

Done.

[nicoe, 2017-06-30 15:15:32]

create the postgis extension on the database creation

[nicoe, 2017-06-30 16:40:26]

Use setuptools find_packages to find packages

[nicoe, 2017-09-14 15:43:21]

Use geojson instead of dbgis

[nicoe, 2017-09-14 16:53:56]

remove comment

[ced, 2017-09-15 09:49:21]

https://codereview.appspot.com/322730043/diff/180001/README
File README (right):

https://codereview.appspot.com/322730043/diff/180001/README#newcode8
README:8: .. _flask_tryton bugtracker: http://trytond-gis.b2ck.com/
wrong name

https://codereview.appspot.com/322730043/diff/180001/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode11
setup.py:11: setup(name='trytond_backend_gis',
This name may be in conflict with the Foundation policy.
It should be prefixed by b2ck_ or we should propose it to host it on Tryton
project.

https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode11
setup.py:11: setup(name='trytond_backend_gis',
Also is it not better to name it: trytond-gis
There are more than just a backend.

https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode44
setup.py:44: # 'trytond>=4.4',
How will we assure the behavior for all series?
Should not we just support one series at a time and use the same numbering as
trytond?

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/__in...
File trytond_backend_gis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/__in...
trytond_backend_gis/__init__.py:8: WGS_84 = 4326
Is it not better to define those constant in const.py instead of public from the
top level of the module?

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
File trytond_backend_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
trytond_backend_gis/fields.py:11: class AsGeoJSON(Function):
is it not better to move it into trytond_gis.sql ?
I think we are going to define all the gis functions to be battery included.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
trytond_backend_gis/fields.py:26: def _sql_type(self):
Should only be available for this backend

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
trytond_backend_gis/fields.py:28: self._geometry_type, self.dimension)
Instead of using python-geojson, it is better to use
https://github.com/geomet/geomet to register a type GEOMETRY and parse wkb.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/post...
File trytond_backend_gis/postgis/table.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/post...
trytond_backend_gis/postgis/table.py:27: # TODO check for type and eventual
migration
It will be good to have a log warning if the type is different.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/post...
trytond_backend_gis/postgis/table.py:30: match = GIS_RE.match(abstract_type)
GIS_RE could have a more meaningful name.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
File trytond_backend_gis/tests/test_fields.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
trytond_backend_gis/tests/test_fields.py:28: 
Could test search with '=' and '!='

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
File trytond_backend_gis/tests/test_gis/tryton.cfg (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
trytond_backend_gis/tests/test_gis/tryton.cfg:1: [tryton]
Is this file necessary?

[nicoe, 2017-09-18 09:33:10]

Use geomet, add tests, move stuffs in cont.py and sql.py

[nicoe, 2017-09-19 10:14:10]

https://codereview.appspot.com/322730043/diff/180001/README
File README (right):

https://codereview.appspot.com/322730043/diff/180001/README#newcode8
README:8: .. _flask_tryton bugtracker: http://trytond-gis.b2ck.com/
On 2017/09/15 09:49:20, ced wrote:
> wrong name

Done.

https://codereview.appspot.com/322730043/diff/180001/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode11
setup.py:11: setup(name='trytond_backend_gis',
On 2017/09/15 09:49:20, ced wrote:
> Also is it not better to name it: trytond-gis
> There are more than just a backend.

Done.

https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode11
setup.py:11: setup(name='trytond_backend_gis',
On 2017/09/15 09:49:20, ced wrote:
> This name may be in conflict with the Foundation policy.
> It should be prefixed by b2ck_ or we should propose it to host it on Tryton
> project.

If it is to follow the tryton numbering scheme then we could propose it.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/__in...
File trytond_backend_gis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/__in...
trytond_backend_gis/__init__.py:8: WGS_84 = 4326
On 2017/09/15 09:49:20, ced wrote:
> Is it not better to define those constant in const.py instead of public from
the
> top level of the module?

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
File trytond_backend_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
trytond_backend_gis/fields.py:11: class AsGeoJSON(Function):
On 2017/09/15 09:49:20, ced wrote:
> is it not better to move it into trytond_gis.sql ?
> I think we are going to define all the gis functions to be battery included.

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
trytond_backend_gis/fields.py:26: def _sql_type(self):
On 2017/09/15 09:49:20, ced wrote:
> Should only be available for this backend

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/fiel...
trytond_backend_gis/fields.py:28: self._geometry_type, self.dimension)
On 2017/09/15 09:49:20, ced wrote:
> Instead of using python-geojson, it is better to use
> https://github.com/geomet/geomet to register a type GEOMETRY and parse wkb.

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/post...
File trytond_backend_gis/postgis/table.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/post...
trytond_backend_gis/postgis/table.py:27: # TODO check for type and eventual
migration
On 2017/09/15 09:49:21, ced wrote:
> It will be good to have a log warning if the type is different.

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/post...
trytond_backend_gis/postgis/table.py:30: match = GIS_RE.match(abstract_type)
On 2017/09/15 09:49:21, ced wrote:
> GIS_RE could have a more meaningful name.

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
File trytond_backend_gis/tests/test_fields.py (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
trytond_backend_gis/tests/test_fields.py:28: 
On 2017/09/15 09:49:21, ced wrote:
> Could test search with '=' and '!='

Done.

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
File trytond_backend_gis/tests/test_gis/tryton.cfg (right):

https://codereview.appspot.com/322730043/diff/180001/trytond_backend_gis/test...
trytond_backend_gis/tests/test_gis/tryton.cfg:1: [tryton]
On 2017/09/15 09:49:21, ced wrote:
> Is this file necessary?

Done.

[ced, 2017-09-20 17:28:21]

https://codereview.appspot.com/322730043/diff/180001/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/180001/setup.py#newcode11
setup.py:11: setup(name='trytond_backend_gis',
On 2017/09/19 10:14:05, nicoe wrote:
> On 2017/09/15 09:49:20, ced wrote:
> > This name may be in conflict with the Foundation policy.
> > It should be prefixed by b2ck_ or we should propose it to host it on Tryton
> > project.
> 
> If it is to follow the tryton numbering scheme then we could propose it.

OK.

https://codereview.appspot.com/322730043/diff/200001/README
File README (right):

https://codereview.appspot.com/322730043/diff/200001/README#newcode7
README:7: 
If we do not have a doc folder, this should at least contain the list of new
fields available and how to configure the backend.

https://codereview.appspot.com/322730043/diff/200001/setup.py
File setup.py (right):

https://codereview.appspot.com/322730043/diff/200001/setup.py#newcode44
setup.py:44: # 'trytond>=4.6',
to be uncommented
also it should use the version of the package.

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/__init__.py
File trytond_gis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/__init__.py#...
trytond_gis/__init__.py:9: class _GeoJSON(dict):
I do not find it is a good place to define such class.
It may generate difficulties later because all submodules need it.
I would put in a _data.py

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/__init__.py#...
trytond_gis/__init__.py:13: if 'meta' not in self:
why not use setdefault?

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/fields.py
File trytond_gis/fields.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/fields.py#ne...
trytond_gis/fields.py:1: # This file is part of trytond_gis.  The COPYRIGHT file
at the top level of
I find that the file should be:

trytond_gis/model/fields.py

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/fields.py#ne...
trytond_gis/fields.py:36: return _GeoJSON(value)
I think it should go thought the database sql_format

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/fields.py#ne...
trytond_gis/fields.py:51: expression = Operator(column,
self._domain_value(operator, value))
I think it will be better to have only one return:

if ...:
   Operator =
   value = null
else:
   Operator =
   value = self._domain_value()
return Operator(column, value)

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/fields.py#ne...
trytond_gis/fields.py:53: return expression
Why not return directly the Operator?

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/__in...
File trytond_gis/postgis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/__in...
trytond_gis/postgis/__init__.py:1: from .table import *
Missing copyright header.

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/data...
File trytond_gis/postgis/database.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/data...
trytond_gis/postgis/database.py:1: # This file is part of trytond_backend_gis. 
The COPYRIGHT file at the top
I find that the file should be trytond_gis/backend/postgis/database.py

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/data...
trytond_gis/postgis/database.py:1: # This file is part of trytond_backend_gis. 
The COPYRIGHT file at the top
Wrong name

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/tabl...
File trytond_gis/postgis/table.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/postgis/tabl...
trytond_gis/postgis/table.py:1: # This file is part of trytond_backend_gis.  The
COPYRIGHT file at the top
wrong name

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/__init...
File trytond_gis/tests/__init__.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/__init...
trytond_gis/tests/__init__.py:1: from .test_gis import register
missing copyright header

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_f...
File trytond_gis/tests/test_fields.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_f...
trytond_gis/tests/test_fields.py:1: # This file is part of trytond_backend_gis. 
The COPYRIGHT file at the top
wrong name

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_f...
trytond_gis/tests/test_fields.py:19: "Testing create/write with GIS types"
It would be better to have a test for each one.

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_f...
trytond_gis/tests/test_fields.py:52: "Testing search with GIS types"
I think it is better to have one test per search.
What we have in trytond is no more maintainable so we should not replicate the
same mistake.

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_f...
trytond_gis/tests/test_fields.py:85: # For some reasons NULL are not taken into
account
It is not some reason, it is because NULL in any operation returns NULL.

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_g...
File trytond_gis/tests/test_gis/__init__.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_g...
trytond_gis/tests/test_gis/__init__.py:1: # This file is part of
trytond_backend_gis.  The COPYRIGHT file at the top
wrong name

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_g...
File trytond_gis/tests/test_gis/gis.py (right):

https://codereview.appspot.com/322730043/diff/200001/trytond_gis/tests/test_g...
trytond_gis/tests/test_gis/gis.py:1: # This file is part of trytond_backend_gis.
 The COPYRIGHT file at the top
wrong name

[nicoe, 2017-12-06 12:26:33]

Upload the fixed version

[ced, 2017-12-31 16:41:01]

Promoted as standard Tryton package at https://bugs.tryton.org/issue2919
https://codereview.tryton.org/43011002 includes drone test, fix test for new
geomet and work to be part of release process of Tryton.