Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 322510043: Support for English note names in Arabic Music (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by pkx166h
Modified:
6 years, 7 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org, hassan.elfatihi_free.fr
Visibility:
Public.

Description

Support for English note names in Arabic Music Issue 5172 Addition of new ly file hel-arabic.ly (documentation is in Issue 5173)

Patch Set 1 #

Patch Set 2 : First patch did not pass tests - fixed indentation issues and what looked like incorrect brace form… #

Patch Set 3 : Fix another brace issue #

Patch Set 4 : Still doesn't compile, noticed some more typos and lots of white space inconsistencies. Fixed those. #

Patch Set 5 : More white space fixes, and an addition to lily-libray.scm to fix the previous compile fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -0 lines) Patch
A ly/hel-arabic.ly View 1 2 3 4 1 chunk +442 lines, -0 lines 0 comments Download
M scm/define-note-names.scm View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
M scm/lily-library.scm View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9
pkx166h
First patch did not pass tests - fixed indentation issues and what looked like incorrect ...
6 years, 7 months ago (2017-08-13 13:59:07 UTC) #1
pkx166h
Fix another brace issue
6 years, 7 months ago (2017-08-13 14:25:57 UTC) #2
pkx166h
Still doesn't compile, noticed some more typos and lots of white space inconsistencies. Fixed those.
6 years, 7 months ago (2017-08-13 18:45:08 UTC) #3
pkx166h
This fails on 'make' and I don't know why... --snip-- Effective prefix: "/home/james/lilypond-git/build/out/share/lilypond/current" PATH="/home/james/lilypond-git/build/out/bin/../bin:/home/james/lilypond-git/build/out/bin:/home/james/lilypond-git/build/lily/out:/home/james/lilypond-git/build/scripts/build/out:/home/james/lilypond-git/build/scripts/out:/home/james/lilypond-git/build/lily/out:/home/james/lilypond-git/build/scripts/build/out:/home/james/lilypond-git/build/scripts/out:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/james/bin:/home/james/lilypond-git/build/out/bin::" [] ...
6 years, 7 months ago (2017-08-13 19:17:09 UTC) #4
dak
On 2017/08/13 19:17:09, pkx166h wrote: > This fails on 'make' and I don't know why... ...
6 years, 7 months ago (2017-08-13 20:10:39 UTC) #5
hassan.elfatihi_free.fr
Hello again , James If it does not work, I suggest these new files that ...
6 years, 7 months ago (2017-08-14 11:14:30 UTC) #6
pkx166h
More white space fixes, and an addition to lily-libray.scm to fix the previous compile fail
6 years, 7 months ago (2017-08-14 21:07:28 UTC) #7
pkx166h
On 2017/08/14 21:07:28, pkx166h wrote: > More white space fixes, and an addition to lily-libray.scm ...
6 years, 7 months ago (2017-08-14 21:07:59 UTC) #8
pkx166h
6 years, 7 months ago (2017-08-22 08:43:50 UTC) #9
author Hassan El fatihi hassan.elfatihi@free.fr
Sun, 13 Aug 2017 12:53:12 +0000 (13:53 +0100)
committer James Lowe pkx166h@gmail.com
Tue, 22 Aug 2017 08:38:38 +0000 (09:38 +0100)
commit 2be5896dc7025f2d5e2b11567dd5d00d32ffb75c
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b