Issue 321860043: Change to use Unicode Emoji files instead of EmojiOne files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 321860043: Change to use Unicode Emoji files instead of EmojiOne files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years ago by fujiwara

Modified:
7 years ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Change to use Unicode Emoji files instead of EmojiOne files EmojiOne Json file have changed the file format since 3.0 [1] Now IBus migrated to use Unicode Emoji files since the EmojiOne file had been used for the emoji categories but it can be done with Unicode emoji-test.txt [2] Use Unicode Emoji 4.0 until 5.0 will be released officially. Unicode Emoji 5.0 is available but fonts does not support it yet. [1] https://github.com/Ranks/emojione/releases/tag/v3.0.0 [2] http://www.unicode.org/Public/emoji/4.0/ Committed: 2f73064d03481c9f34d278dd19d1a4427d6ecb27

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+759 lines, -184 lines)			Patch
M	bindings/vala/Makefile.am	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	configure.ac	View		3 chunks	+12 lines, -15 lines	0 comments	Download
M	data/annotations/Makefile.am	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	data/annotations/en_ascii.xml	View		1 chunk	+56 lines, -0 lines	0 comments	Download
M	po/POTFILES.in	View		3 chunks	+2 lines, -1 line	0 comments	Download
M	po/POTFILES.skip	View		2 chunks	+1 line, -1 line	0 comments	Download
M	src/Makefile.am	View	1	4 chunks	+13 lines, -4 lines	0 comments	Download
M	src/emoji-parser.c	View	1	11 chunks	+571 lines, -61 lines	0 comments	Download
M	src/ibusemoji.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/ibusemoji.c	View		14 chunks	+4 lines, -43 lines	0 comments	Download
A +	src/ibusemojigen.h	View		2 chunks	+18 lines, -10 lines	0 comments	Download
M	ui/gtk3/Makefile.am	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ui/gtk3/emojier.vala	View		8 chunks	+77 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

7 years ago (2017-04-28 04:10:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
2f73064d03481c9f34d278dd19d1a4427d6ecb27 (presubmit successful).

Expand All Messages | Collapse All Messages