Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 321560043: Integrate lone post-events into surrounding expressions.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by dak
Modified:
1 week, 4 days ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Integrate lone post-events into surrounding expressions. Reattaching post-events to a preceding music variable or music function call (or expression) is often desired but was unsupported. The problem with supporting such expressions _everywhere_ is that it breaks the use of c-\single \dynamicUp \f since then \f is attached to \dynamicUp instead of becoming the second argument to \single, due to operator precedence. So reattaching lone post-events is only done with lower precedence in selected constructs. This issue does not yet contain regression tests, changes entries, or documentation. I would want to solicit feedback on how useful people find it since it messes with the syntax. Contains commits (reverse order): Integrate lone post-events into chords Reattaching post-events to a preceding music variable or music function call (or expression) is often desired but was unsupported. This commit caters for the support inside of chords. Allow lone postevents in braced lists Reattaching post-events to a preceding music variable or music function call (or expression) is often desired but was unsupported. This commit caters for the support in braced lists. The problem with supporting such expressions _everywhere_ is that it breaks the use of c-\single \dynamicUp \f since then \f is attached to \dynamicUp instead of becoming the second argument to \single, due to operator precedence. So reattaching lone post-events is only done with lower precedence in selected constructs. Parser: Add reverse_music_list function This function does not just reverse a music list but also integrates post events into the respective preceding expressions. If that is not possible, a warning is printed and they are either dropped or attached to an empty chord (depending on a call parameter). If a list consists only of post-events, it might be returned as a post-event, too. Again, depending on a parameter. This is useful for #{ -2 -3 #} and its ilk. Also adds add_post_events function.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -55 lines) Patch
M lily/parser.yy View 12 chunks +159 lines, -55 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted