Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3013)

Issue 321400043: Output better message for wrong argument of dash-definiton

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by thomasmorley651
Modified:
6 years, 8 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Output better message for wrong argument of dash-definiton Previously an argument like '(0 1.0 0.5 0.5) passed the pair?-typecheck, segfaulting later. Thus a new predicate, list-of-lists? is introduced.

Patch Set 1 #

Patch Set 2 : adds list-of-lists? in lilypond-scheme-predicates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M scm/c++.scm View 1 chunk +3 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/lily.scm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
thomasmorley651
Please review
6 years, 8 months ago (2017-08-01 17:17:43 UTC) #1
thomasmorley651
adds list-of-lists? in lilypond-scheme-predicates
6 years, 8 months ago (2017-08-02 20:44:07 UTC) #2
dak
On 2017/08/02 20:44:07, thomasmorley651 wrote: > adds list-of-lists? in lilypond-scheme-predicates Frankly, I find that sort-of ...
6 years, 8 months ago (2017-08-02 20:53:46 UTC) #3
thomasmorley651
6 years, 8 months ago (2017-08-02 21:02:39 UTC) #4
On 2017/08/02 20:53:46, dak wrote:
> On 2017/08/02 20:44:07, thomasmorley651 wrote:
> > adds list-of-lists? in lilypond-scheme-predicates
> 
> Frankly, I find that sort-of pointless: this just replaces one insufficient
> predicate with a slightly less insufficient one.  It's nice that this triggers
> an error at the point of call rather than evaluation, but it seems like proper
> value-checking at the point of evaluation is still called for when a generic
> predicate like list-of-list? is being used.

Well, I get your point.
Nevertheless, segfaulting with no other message is worse.
Could you elaborate a bit more verbose how to do it better?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b