Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9621)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 320710043: [dfvfs] Changes to replace stat with attributes #52 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by Joachim Metz
Modified:
6 years, 9 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Changes to replace stat with attributes #52 Depends on: https://codereview.appspot.com/323180043/

Patch Set 1 : Changes to replace stat with attributes #52 #

Patch Set 2 : Changes to replace stat with attributes #52 #

Total comments: 8

Patch Set 3 : Changes after merge and review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+919 lines, -710 lines) Patch
M dfvfs/vfs/bde_file_entry.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M dfvfs/vfs/compressed_stream_file_entry.py View 1 2 1 chunk +36 lines, -17 lines 0 comments Download
M dfvfs/vfs/cpio_file_entry.py View 1 2 5 chunks +98 lines, -105 lines 0 comments Download
M dfvfs/vfs/cpio_file_system.py View 1 2 4 chunks +36 lines, -12 lines 0 comments Download
M dfvfs/vfs/encoded_stream_file_entry.py View 1 2 2 chunks +35 lines, -16 lines 0 comments Download
M dfvfs/vfs/encrypted_stream_file_entry.py View 1 2 1 chunk +36 lines, -17 lines 0 comments Download
M dfvfs/vfs/fake_file_entry.py View 1 2 8 chunks +54 lines, -29 lines 0 comments Download
M dfvfs/vfs/fake_file_system.py View 1 2 8 chunks +9 lines, -54 lines 0 comments Download
M dfvfs/vfs/file_entry.py View 1 2 5 chunks +6 lines, -1 line 0 comments Download
M dfvfs/vfs/fvde_file_entry.py View 1 2 1 chunk +26 lines, -18 lines 2 comments Download
M dfvfs/vfs/gzip_file_entry.py View 1 2 1 chunk +49 lines, -24 lines 0 comments Download
M dfvfs/vfs/lvm_file_entry.py View 1 2 4 chunks +44 lines, -74 lines 0 comments Download
M dfvfs/vfs/lvm_file_system.py View 1 2 6 chunks +25 lines, -12 lines 0 comments Download
M dfvfs/vfs/ntfs_file_entry.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/os_file_entry.py View 1 2 8 chunks +101 lines, -91 lines 0 comments Download
M dfvfs/vfs/tar_file_entry.py View 1 2 6 chunks +50 lines, -48 lines 0 comments Download
M dfvfs/vfs/tar_file_system.py View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
M dfvfs/vfs/tsk_file_entry.py View 1 2 14 chunks +213 lines, -147 lines 0 comments Download
M dfvfs/vfs/tsk_file_system.py View 1 2 10 chunks +58 lines, -27 lines 0 comments Download
M dfvfs/vfs/tsk_partition_file_entry.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/vfs/vshadow_file_entry.py View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M dfvfs/vfs/zip_file_system.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/vfs/cpio_file_system.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/vfs/lvm_file_entry.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/vfs/tsk_file_entry.py View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 13
Joachim Metz
6 years, 10 months ago (2017-06-25 19:12:16 UTC) #1
Joachim Metz
Code updated.
6 years, 10 months ago (2017-06-26 06:01:00 UTC) #2
Joachim Metz
Code updated.
6 years, 10 months ago (2017-06-26 07:17:08 UTC) #3
Joachim Metz
Code updated.
6 years, 10 months ago (2017-06-26 18:36:44 UTC) #4
Joachim Metz
Code updated.
6 years, 10 months ago (2017-06-26 19:10:49 UTC) #5
Joachim Metz
Code updated.
6 years, 10 months ago (2017-07-13 07:25:35 UTC) #6
onager
https://codereview.appspot.com/320710043/diff/100001/dfvfs/vfs/fvde_file_entry.py File dfvfs/vfs/fvde_file_entry.py (right): https://codereview.appspot.com/320710043/diff/100001/dfvfs/vfs/fvde_file_entry.py#newcode29 dfvfs/vfs/fvde_file_entry.py:29: entry emulated by the corresponding file system. copy paste ...
6 years, 9 months ago (2017-07-18 15:44:24 UTC) #7
Joachim Metz
https://codereview.appspot.com/320710043/diff/100001/dfvfs/vfs/fvde_file_entry.py File dfvfs/vfs/fvde_file_entry.py (right): https://codereview.appspot.com/320710043/diff/100001/dfvfs/vfs/fvde_file_entry.py#newcode29 dfvfs/vfs/fvde_file_entry.py:29: entry emulated by the corresponding file system. On 2017/07/18 ...
6 years, 9 months ago (2017-07-18 19:40:37 UTC) #8
Joachim Metz
Code updated.
6 years, 9 months ago (2017-07-18 19:44:05 UTC) #9
Joachim Metz
Some merge changes leaking into the CL
6 years, 9 months ago (2017-07-18 19:44:55 UTC) #10
onager
One copy paste docstring error remaining, LGTM https://codereview.appspot.com/320710043/diff/120001/dfvfs/vfs/fvde_file_entry.py File dfvfs/vfs/fvde_file_entry.py (right): https://codereview.appspot.com/320710043/diff/120001/dfvfs/vfs/fvde_file_entry.py#newcode27 dfvfs/vfs/fvde_file_entry.py:27: is_virtual (Optional[bool]): ...
6 years, 9 months ago (2017-07-19 10:13:47 UTC) #11
Joachim Metz
https://codereview.appspot.com/320710043/diff/120001/dfvfs/vfs/fvde_file_entry.py File dfvfs/vfs/fvde_file_entry.py (right): https://codereview.appspot.com/320710043/diff/120001/dfvfs/vfs/fvde_file_entry.py#newcode27 dfvfs/vfs/fvde_file_entry.py:27: is_virtual (Optional[bool]): True if the file entry is a ...
6 years, 9 months ago (2017-07-19 15:40:16 UTC) #12
Joachim Metz
6 years, 9 months ago (2017-07-19 15:41:46 UTC) #13 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dfdatetime2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b