[dftimewolf] Support --keepalive. Minor docstring and formatting fixes.

[dftimewolf] Support --keepalive. Minor docstring and formatting fixes.

[jberggren, 2017-01-24 13:53:36]

Just some small nits

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py
File dftimewolf/lib/collectors.py (right):

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:350: keepalive (Optional [bool]): toggle for
scheduling an extra KeepAlive flow
There is no other keepalive, right? in that case, drop the "extra"?

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:525: self.console_out.VerboseOut(u'KeepAlive Flow
{0:s}: Scheduled'.format(
I usually cut the line at the first parenthesis.

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:597: keepalive (Optional[bool]): toggle for
scheduling an extra KeepAlive flow
Same comment as above

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_cli.py
File dftimewolf/timewolf_cli.py (right):

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_cli.py#ne...
dftimewolf/timewolf_cli.py:47: gflags.DEFINE_boolean(u'keepalive', False,
u'Schedule an extra KeepAlive flow')
-extra

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_collect.py
File dftimewolf/timewolf_collect.py (right):

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_collect.p...
dftimewolf/timewolf_collect.py:37: gflags.DEFINE_boolean(u'keepalive', False,
u'Schedule an extra KeepAlive flow')
-extra

[someguyiknow, 2017-01-24 14:19:07]

Code updated.

[someguyiknow, 2017-01-24 14:19:34]

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py
File dftimewolf/lib/collectors.py (right):

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:350: keepalive (Optional [bool]): toggle for
scheduling an extra KeepAlive flow
On 2017/01/24 13:53:36, jberggren wrote:
> There is no other keepalive, right? in that case, drop the "extra"?

Done.

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:525: self.console_out.VerboseOut(u'KeepAlive Flow
{0:s}: Scheduled'.format(
On 2017/01/24 13:53:36, jberggren wrote:
> I usually cut the line at the first parenthesis.

Pyformat keeps moving it back this way.

https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
dftimewolf/lib/collectors.py:597: keepalive (Optional[bool]): toggle for
scheduling an extra KeepAlive flow
On 2017/01/24 13:53:36, jberggren wrote:
> Same comment as above

Done.

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_cli.py
File dftimewolf/timewolf_cli.py (right):

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_cli.py#ne...
dftimewolf/timewolf_cli.py:47: gflags.DEFINE_boolean(u'keepalive', False,
u'Schedule an extra KeepAlive flow')
On 2017/01/24 13:53:36, jberggren wrote:
> -extra

Done.

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_collect.py
File dftimewolf/timewolf_collect.py (right):

https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_collect.p...
dftimewolf/timewolf_collect.py:37: gflags.DEFINE_boolean(u'keepalive', False,
u'Schedule an extra KeepAlive flow')
On 2017/01/24 13:53:36, jberggren wrote:
> -extra

Done.

[jberggren, 2017-01-24 14:25:52]

On 2017/01/24 14:19:34, someguyiknow wrote:
> https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py
> File dftimewolf/lib/collectors.py (right):
> 
>
https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
> dftimewolf/lib/collectors.py:350: keepalive (Optional [bool]): toggle for
> scheduling an extra KeepAlive flow
> On 2017/01/24 13:53:36, jberggren wrote:
> > There is no other keepalive, right? in that case, drop the "extra"?
> 
> Done.
> 
>
https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
> dftimewolf/lib/collectors.py:525: self.console_out.VerboseOut(u'KeepAlive Flow
> {0:s}: Scheduled'.format(
> On 2017/01/24 13:53:36, jberggren wrote:
> > I usually cut the line at the first parenthesis.
> 
> Pyformat keeps moving it back this way.
> 
>
https://codereview.appspot.com/320030043/diff/1/dftimewolf/lib/collectors.py#...
> dftimewolf/lib/collectors.py:597: keepalive (Optional[bool]): toggle for
> scheduling an extra KeepAlive flow
> On 2017/01/24 13:53:36, jberggren wrote:
> > Same comment as above
> 
> Done.
> 
> https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_cli.py
> File dftimewolf/timewolf_cli.py (right):
> 
>
https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_cli.py#ne...
> dftimewolf/timewolf_cli.py:47: gflags.DEFINE_boolean(u'keepalive', False,
> u'Schedule an extra KeepAlive flow')
> On 2017/01/24 13:53:36, jberggren wrote:
> > -extra
> 
> Done.
> 
> https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_collect.py
> File dftimewolf/timewolf_collect.py (right):
> 
>
https://codereview.appspot.com/320030043/diff/1/dftimewolf/timewolf_collect.p...
> dftimewolf/timewolf_collect.py:37: gflags.DEFINE_boolean(u'keepalive', False,
> u'Schedule an extra KeepAlive flow')
> On 2017/01/24 13:53:36, jberggren wrote:
> > -extra
> 
> Done.

LGTM

[someguyiknow, 2017-01-24 14:56:09]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close keepalive