Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6308)

Issue 320000043: TBR: DrMi#1795 drreg: add drreg_restore_app_values()

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by bruening
Modified:
7 years, 3 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- DrMi#1795 drreg: add drreg_restore_app_values() Dr. Memory's in-progress conversion to use drreg has exposed a few missing features: when restoring app values, all spilled registers are not necessarily known as other components than the current code could have spilled some. With drreg's lazy restores, a routine to restore *all* registers used by an operand is needed. We add drreg_restore_app_values() for this purpose. Adds a few tests as well. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -3 lines) Patch
M api/docs/release.dox View 1 chunk +1 line, -0 lines 0 comments Download
M ext/drreg/drreg.h View 2 chunks +28 lines, -1 line 0 comments Download
M ext/drreg/drreg.c View 2 chunks +34 lines, -1 line 0 comments Download
M suite/tests/client-interface/drreg-test.dll.c View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 2
bruening
7 years, 3 months ago (2017-01-18 04:56:50 UTC) #1
bruening
7 years, 3 months ago (2017-01-18 04:56:52 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/3479fcb277b181077c63ac4208c363d...

Final commit log: 
---------------
DrMi#1795 drreg: add drreg_restore_app_values()

Dr. Memory's in-progress conversion to use drreg has exposed a few missing
features: when restoring app values, all spilled registers are not
necessarily known as other components than the current code could have
spilled some.  With drreg's lazy restores, a routine to restore *all*
registers used by an operand is needed.  We add drreg_restore_app_values()
for this purpose.

Adds a few tests as well.

Review-URL: https://codereview.appspot.com/320000043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b