i#1958: Separate C++ literals and macros. Fix breakage from 24c4f7c.

Commit log for first patchset:
---------------
i#1958: Separate C++ literals and macros. Fix breakage from 24c4f7c.

Error message on Debian i386 stretch DynamoRIO was:
.../suite/tests/client-interface/annotation-detection.cpp:69:5: error:
unable to find string literal operator 'operator""base' with 'const
char [228]', 'unsigned int' arguments
---------------

[bruening, 2017-01-16 16:45:57]

On 2017/01/16 12:40:08, Edmund.Grimley.Evans wrote:
> i#1958: Separate C++ literals and macros. Fix breakage from 24c4f7c.

nit: commit style violation: colon is wrong place for multi-CL-issue

suggest: add a CDash job so someone notices gcc6 breakage

else LGTM

[Edmund.Grimley.Evans, 2017-01-16 17:34:08]

On 2017/01/16 16:45:57, bruening wrote:
> On 2017/01/16 12:40:08, Edmund.Grimley.Evans wrote:
> > i#1958: Separate C++ literals and macros. Fix breakage from 24c4f7c.
> 
> nit: commit style violation: colon is wrong place for multi-CL-issue

I'm not sure whether I should refer to i#1958 ("Add support for gcc 6"), i#1959
("Compile error: c++11 invalid suffix on literal"), or i#2050 (the issue
referred to in 24c4f7c, which is being corrected here).

[Edmund.Grimley.Evans, 2017-01-16 17:38:17]

On 2017/01/16 17:34:08, Edmund.Grimley.Evans wrote:
> On 2017/01/16 16:45:57, bruening wrote:
> > On 2017/01/16 12:40:08, Edmund.Grimley.Evans wrote:
> > > i#1958: Separate C++ literals and macros. Fix breakage from 24c4f7c.
> > 
> > nit: commit style violation: colon is wrong place for multi-CL-issue
> 
> I'm not sure whether I should refer to i#1958 ("Add support for gcc 6"),
i#1959
> ("Compile error: c++11 invalid suffix on literal"), or i#2050 (the issue
> referred to in 24c4f7c, which is being corrected here).

Perhaps not i#1959, because it's closed, though that's what I used in ce6b414,
after the issue had been closed. I could reopen it specially...

[bruening, 2017-01-16 18:12:58]

On 2017/01/16 17:38:17, Edmund.Grimley.Evans wrote:
> On 2017/01/16 17:34:08, Edmund.Grimley.Evans wrote:
> > On 2017/01/16 16:45:57, bruening wrote:
> > > On 2017/01/16 12:40:08, Edmund.Grimley.Evans wrote:
> > > > i#1958: Separate C++ literals and macros. Fix breakage from 24c4f7c.
> > > 
> > > nit: commit style violation: colon is wrong place for multi-CL-issue
> > 
> > I'm not sure whether I should refer to i#1958 ("Add support for gcc 6"),
> i#1959
> > ("Compile error: c++11 invalid suffix on literal"), or i#2050 (the issue
> > referred to in 24c4f7c, which is being corrected here).
> 
> Perhaps not i#1959, because it's closed, though that's what I used in ce6b414,
> after the issue had been closed. I could reopen it specially...

For something like this it seems fine to me to refer to the closed issue and not
bother to reopen and reclose it.

[Edmund.Grimley.Evans, 2017-01-17 08:43:01]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/ec2bbce298fb46ad91b279c9a5d2375...

Final commit log: 
---------------
i#1959: Separate C++ literals and macros. Fix breakage from 24c4f7c.

Error message on Debian i386 stretch DynamoRIO was:
.../suite/tests/client-interface/annotation-detection.cpp:69:5: error:
unable to find string literal operator 'operator""base' with 'const
char [228]', 'unsigned int' arguments

Xref #1958.

Review-URL: https://codereview.appspot.com/319990043
---------------

[bruening, 2017-01-17 13:27:30]

On 2017/01/17 08:43:01, Edmund.Grimley.Evans wrote:
> Committed as
>
https://github.com/DynamoRIO/dynamorio/commit/ec2bbce298fb46ad91b279c9a5d2375...
> 
> Final commit log: 
> ---------------
> i#1959: Separate C++ literals and macros. Fix breakage from 24c4f7c.

nit: this was never changed...