Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 319930043: [plaso] Migrated plaso timestamp to dfdatetime for SQLite plugins #910 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by Joachim Metz
Modified:
7 years, 1 month ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Migrated plaso timestamp to dfdatetime for SQLite plugins #910

Patch Set 1 #

Patch Set 2 : Migrated plaso timestamp to dfdatetime for SQLite plugins #910 #

Total comments: 6

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1573 lines, -1497 lines) Patch
M plaso/formatters/__init__.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M plaso/formatters/android_webview.py View 2 chunks +10 lines, -6 lines 0 comments Download
M plaso/formatters/android_webviewcache.py View 1 chunk +9 lines, -19 lines 0 comments Download
M plaso/formatters/gdrive.py View 2 chunks +48 lines, -0 lines 0 comments Download
M plaso/formatters/twitter_ios.py View 4 chunks +11 lines, -28 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_calls.py View 2 chunks +45 lines, -38 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_sms.py View 2 chunks +36 lines, -34 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_webview.py View 1 2 3 chunks +64 lines, -64 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_webviewcache.py View 1 2 2 chunks +34 lines, -40 lines 0 comments Download
M plaso/parsers/sqlite_plugins/appusage.py View 3 chunks +36 lines, -30 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome.py View 1 2 7 chunks +134 lines, -103 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome_cookies.py View 5 chunks +58 lines, -48 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome_extension_activity.py View 2 chunks +57 lines, -31 lines 0 comments Download
M plaso/parsers/sqlite_plugins/firefox.py View 6 chunks +25 lines, -20 lines 0 comments Download
M plaso/parsers/sqlite_plugins/firefox_cookies.py View 3 chunks +83 lines, -71 lines 0 comments Download
M plaso/parsers/sqlite_plugins/gdrive.py View 5 chunks +74 lines, -79 lines 0 comments Download
M plaso/parsers/sqlite_plugins/imessage.py View 2 chunks +48 lines, -39 lines 0 comments Download
M plaso/parsers/sqlite_plugins/kik_ios.py View 2 chunks +41 lines, -30 lines 0 comments Download
M plaso/parsers/sqlite_plugins/ls_quarantine.py View 2 chunks +36 lines, -26 lines 0 comments Download
M plaso/parsers/sqlite_plugins/mac_document_versions.py View 4 chunks +39 lines, -29 lines 0 comments Download
M plaso/parsers/sqlite_plugins/mackeeper_cache.py View 6 chunks +142 lines, -111 lines 0 comments Download
M plaso/parsers/sqlite_plugins/skype.py View 9 chunks +257 lines, -285 lines 0 comments Download
M plaso/parsers/sqlite_plugins/twitter_ios.py View 2 chunks +113 lines, -130 lines 0 comments Download
M plaso/parsers/sqlite_plugins/zeitgeist.py View 2 chunks +30 lines, -25 lines 0 comments Download
M tests/formatters/android_webview.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/formatters/android_webviewcache.py View 1 chunk +4 lines, -28 lines 0 comments Download
M tests/formatters/twitter_ios.py View 2 chunks +12 lines, -65 lines 0 comments Download
M tests/parsers/sqlite_plugins/android_calls.py View 2 chunks +13 lines, -13 lines 0 comments Download
M tests/parsers/sqlite_plugins/android_sms.py View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/parsers/sqlite_plugins/android_webview.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/sqlite_plugins/android_webviewcache.py View 1 2 2 chunks +18 lines, -7 lines 0 comments Download
M tests/parsers/sqlite_plugins/chrome_cookies.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/sqlite_plugins/firefox_cookies.py View 3 chunks +27 lines, -25 lines 0 comments Download
M tests/parsers/sqlite_plugins/gdrive.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/sqlite_plugins/imessage.py View 1 chunk +10 lines, -19 lines 0 comments Download
M tests/parsers/sqlite_plugins/kik_ios.py View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/parsers/sqlite_plugins/skype.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/sqlite_plugins/twitter_ios.py View 8 chunks +24 lines, -20 lines 0 comments Download
M tests/parsers/sqlite_plugins/zeitgeist.py View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8
Joachim Metz
7 years, 4 months ago (2016-12-30 16:03:40 UTC) #1
Joachim Metz
Code updated.
7 years, 4 months ago (2017-01-03 07:31:56 UTC) #2
Joachim Metz
Code updated.
7 years, 4 months ago (2017-01-03 07:35:15 UTC) #3
onager
https://codereview.appspot.com/319930043/diff/40001/plaso/parsers/sqlite_plugins/android_webview.py File plaso/parsers/sqlite_plugins/android_webview.py (right): https://codereview.appspot.com/319930043/diff/40001/plaso/parsers/sqlite_plugins/android_webview.py#newcode94 plaso/parsers/sqlite_plugins/android_webview.py:94: # for cookies that have no expiry. We have ...
7 years, 2 months ago (2017-02-28 12:01:27 UTC) #4
Joachim Metz
https://codereview.appspot.com/319930043/diff/40001/plaso/parsers/sqlite_plugins/android_webview.py File plaso/parsers/sqlite_plugins/android_webview.py (right): https://codereview.appspot.com/319930043/diff/40001/plaso/parsers/sqlite_plugins/android_webview.py#newcode94 plaso/parsers/sqlite_plugins/android_webview.py:94: # for cookies that have no expiry. On 2017/02/28 ...
7 years, 1 month ago (2017-03-11 09:37:10 UTC) #5
Joachim Metz
Code updated.
7 years, 1 month ago (2017-03-11 09:44:26 UTC) #6
onager
LGTM
7 years, 1 month ago (2017-03-24 10:51:04 UTC) #7
Joachim Metz
7 years, 1 month ago (2017-03-25 08:49:51 UTC) #8 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dfdatetime_sqlite
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b