Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 319870043: Fix scripts for environments where "set -ux" carries over

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by trueroad
Modified:
7 years, 4 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 5013: Fix scripts for environments where "set -ux" carries over Normally, in Bourne shell scripts, "set -ux" does not carry over to child processes. However, under some conditions, it carries over to child processes. (E.g. environment variable SHELLOPTS exists.) If "set -ux" in smart-autogen.sh carries over to the child processes, autoconf fails. In order to avoid the issue, this commit makes smart-autogen.sh and smart-configure.sh use "set +ux" to cancel the effect of "set -ux" just before invoking the child process. Likewise, this commit also removes "set -e" for avoiding "set -e" carrying over, and adds alternative error handling.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M smart-autogen.sh View 1 chunk +1 line, -2 lines 0 comments Download
M smart-configure.sh View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM.
7 years, 4 months ago (2016-12-16 17:49:07 UTC) #1
trueroad
7 years, 4 months ago (2016-12-22 11:58:25 UTC) #2
I've pushed to staging.

commit d73ef0f31f2e154633da4a763b9a20a13b920ca2
Issue 5013: Fix scripts for environments where "set -ux" carries over
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b