Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9296)

Issue 319830043: TBR: i#1984 sigaction: add missing error checks for sigaction params

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by bruening
Modified:
7 years, 4 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1984 sigaction: add missing error checks for sigaction params Adds missing error checks for invalid memory and other errors in sigaction parameters, as we're often emulating the entire system call. Enables the linux.sigaction_nosignals test. Fixes #1984 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -76 lines) Patch
M core/dispatch.c View 1 chunk +1 line, -0 lines 0 comments Download
M core/unix/os.c View 6 chunks +29 lines, -13 lines 0 comments Download
M core/unix/os_private.h View 2 chunks +14 lines, -6 lines 0 comments Download
M core/unix/signal.c View 8 chunks +132 lines, -54 lines 0 comments Download
M core/unix/signal_private.h View 1 chunk +6 lines, -0 lines 0 comments Download
M suite/tests/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M suite/tests/linux/sigaction_nosignals.c View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 4 months ago (2016-12-11 05:16:56 UTC) #1
bruening
7 years, 4 months ago (2016-12-11 05:16:59 UTC) #2
Committed as
https://github.com/DynamoRIO/dynamorio/commit/0dcf7150ddf5fdc35ce9311c2c72985...

Final commit log: 
---------------
i#1984 sigaction: add missing error checks for sigaction params

Adds missing error checks for invalid memory and other errors in sigaction
parameters, as we're often emulating the entire system call.

Enables the linux.sigaction_nosignals test.

Fixes #1984

Review-URL: https://codereview.appspot.com/319830043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b