i#2075 flaky pthread_exit test: relax vmm_heap_exit check.

Commit log for first patchset:
---------------
i#2075 flaky pthread_exit test: relax vmm_heap_exit check.

Adds flag dynamo_thread_init_exit to indicate if the process exits during any
threads init.  Relax vmm_heap_exit check if dynamo_thread_init_exit is true.

Fixes #2075
---------------

[bruening, 2016-11-26 17:38:39]

Can we simply free the dstack?

If that's hard then can we make this debug-only.

Shouldn't need another look so LGTM w/ comments.

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c
File core/dynamo.c (right):

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c#newcode2068
core/dynamo.c:2068: bool dynamo_thread_init_exit = false;
The name is confusing vs the thread_initexit_lock: how about a more descriptive
name like "thread_init_during_process_exit".

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c#newcode2068
core/dynamo.c:2068: bool dynamo_thread_init_exit = false;
This can be DEBUG-only

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c#newcode2116
core/dynamo.c:2116: dynamo_thread_init_exit = true;
Can we free the dstack here instead?  Does control ever make it out of the loop?

https://codereview.appspot.com/319770043/diff/1/core/globals.h
File core/globals.h (right):

https://codereview.appspot.com/319770043/diff/1/core/globals.h#newcode450
core/globals.h:450: extern bool dynamo_thread_init_exit;   /* process exit in
middle of any thread init? */
DEBUG-only: move up above

[zhaoqin, 2016-11-27 01:21:28]

Commit log for latest patchset:
---------------
i#2075 flaky pthread_exit test: relax vmm_heap_exit check.

Adds flag dynamo_thread_init_during_process_exit to indicate if the process
exits during any threads init.
Relax vmm_heap_exit check if dynamo_thread_init_during_process_exit is true.

Review-URL: https://codereview.appspot.com/319770043
---------------

[zhaoqin, 2016-11-27 01:22:30]

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c
File core/dynamo.c (right):

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c#newcode2068
core/dynamo.c:2068: bool dynamo_thread_init_exit = false;
On 2016/11/26 17:38:38, bruening wrote:
> The name is confusing vs the thread_initexit_lock: how about a more
descriptive
> name like "thread_init_during_process_exit".

Done.

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c#newcode2068
core/dynamo.c:2068: bool dynamo_thread_init_exit = false;
On 2016/11/26 17:38:38, bruening wrote:
> This can be DEBUG-only

Done.

https://codereview.appspot.com/319770043/diff/1/core/dynamo.c#newcode2116
core/dynamo.c:2116: dynamo_thread_init_exit = true;
On 2016/11/26 17:38:38, bruening wrote:
> Can we free the dstack here instead?  Does control ever make it out of the
loop?

using call_switch_stack?
I still need some TLS memory stack for running the loop. Seems not worth the
effort for such cases.

I can leave the issue open for the real fix.

https://codereview.appspot.com/319770043/diff/1/core/globals.h
File core/globals.h (right):

https://codereview.appspot.com/319770043/diff/1/core/globals.h#newcode450
core/globals.h:450: extern bool dynamo_thread_init_exit;   /* process exit in
middle of any thread init? */
On 2016/11/26 17:38:38, bruening wrote:
> DEBUG-only: move up above

Done.

[zhaoqin, 2016-11-28 18:24:06]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/45dd931cbb5c63ede43dac5703ab622...

Final commit log: 
---------------
i#2075 flaky pthread_exit test: relax vmm_heap_exit check.

Adds flag dynamo_thread_init_during_process_exit to indicate if the process
exits during any threads init.
Relax vmm_heap_exit check if dynamo_thread_init_during_process_exit is true.

Review-URL: https://codereview.appspot.com/319770043
---------------