Issue 319720043: TBR: i#1925: use multiple tries to avoid drstrace_unit_tests flakiness

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 319720043: TBR: i#1925: use multiple tries to avoid drstrace_unit_tests flakiness

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by bruening

Modified:
7 years, 5 months ago

Reviewers:
zhaoqin

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1925: use multiple tries to avoid drstrace_unit_tests flakiness To avoid flakiness where the MS symbol server sometimes fails, we have drstrace_unit_tests try multiple times to download symbols before failing the test. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	drstrace/CMakeLists.txt	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	drstrace/drstrace_unit_tests.c	View		4 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

bruening

7 years, 5 months ago (2016-11-14 05:37:51 UTC) #1

Committed as
https://github.com/DynamoRIO/drmemory/commit/cf5c840553fcbe006dd21efa6b99d4b0...

Final commit log: 
---------------
i#1925: use multiple tries to avoid drstrace_unit_tests flakiness

To avoid flakiness where the MS symbol server sometimes fails, we have
drstrace_unit_tests try multiple times to download symbols before
failing the test.

Review-URL: https://codereview.appspot.com/319720043
---------------

Expand All Messages | Collapse All Messages